mirror of
https://github.com/Unleash/unleash.git
synced 2024-11-01 19:07:38 +01:00
4adc977ba0
Variants were not being properly handled in the `flag-resolver`: The
fact that the default value of the variant is not falsy made it so we
never asked the external flag resolver for the value.
This also moves the logic from `Variant | undefined` to `Variant` where
we use the `getDefaultVariant()` helper method to return us a [default
variant](55274e4953/src/variant.ts (L37-L42)
).
177 lines
4.7 KiB
TypeScript
177 lines
4.7 KiB
TypeScript
import { PayloadType } from 'unleash-client';
|
|
import { defaultExperimentalOptions, IFlagKey } from '../types/experimental';
|
|
import FlagResolver, { getVariantValue } from './flag-resolver';
|
|
import { IExperimentalOptions } from '../types/experimental';
|
|
import { getDefaultVariant } from 'unleash-client/lib/variant';
|
|
|
|
test('should produce empty exposed flags', () => {
|
|
const resolver = new FlagResolver(defaultExperimentalOptions);
|
|
|
|
const result = resolver.getAll();
|
|
|
|
expect(result.anonymiseEventLog).toBe(false);
|
|
});
|
|
|
|
test('should produce UI flags with extra dynamic flags', () => {
|
|
const config = {
|
|
...defaultExperimentalOptions,
|
|
flags: { extraFlag: false },
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.extraFlag).toBe(false);
|
|
});
|
|
|
|
test('should use external resolver for dynamic flags', () => {
|
|
const externalResolver = {
|
|
isEnabled: (name: string) => {
|
|
if (name === 'extraFlag') {
|
|
return true;
|
|
}
|
|
},
|
|
getVariant: () => getDefaultVariant(),
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.extraFlag).toBe(true);
|
|
});
|
|
|
|
test('should not use external resolver for enabled experiments', () => {
|
|
const externalResolver = {
|
|
isEnabled: () => {
|
|
return false;
|
|
},
|
|
getVariant: () => getDefaultVariant(),
|
|
};
|
|
|
|
const config = {
|
|
flags: { should_be_enabled: true, extraFlag: false },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.should_be_enabled).toBe(true);
|
|
});
|
|
|
|
test('should load experimental flags', () => {
|
|
const externalResolver = {
|
|
isEnabled: () => {
|
|
return false;
|
|
},
|
|
getVariant: () => getDefaultVariant(),
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false, someFlag: true },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
expect(resolver.isEnabled('someFlag' as IFlagKey)).toBe(true);
|
|
expect(resolver.isEnabled('extraFlag' as IFlagKey)).toBe(false);
|
|
});
|
|
|
|
test('should load experimental flags from external provider', () => {
|
|
const externalResolver = {
|
|
isEnabled: (name: string) => {
|
|
if (name === 'extraFlag') {
|
|
return true;
|
|
}
|
|
},
|
|
getVariant: () => getDefaultVariant(),
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false, someFlag: true },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
expect(resolver.isEnabled('someFlag' as IFlagKey)).toBe(true);
|
|
expect(resolver.isEnabled('extraFlag' as IFlagKey)).toBe(true);
|
|
});
|
|
|
|
test('should support variant flags', () => {
|
|
const variant = {
|
|
enabled: true,
|
|
name: 'variant',
|
|
payload: {
|
|
type: PayloadType.STRING,
|
|
value: 'variant-A',
|
|
},
|
|
};
|
|
|
|
const externalResolver = {
|
|
isEnabled: () => true,
|
|
getVariant: (name: string) => {
|
|
if (name === 'extraFlag') {
|
|
return variant;
|
|
}
|
|
return getDefaultVariant();
|
|
},
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: undefined, someFlag: true, otherflag: false },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
expect(resolver.getVariant('someFlag' as IFlagKey)).toStrictEqual(
|
|
getDefaultVariant(),
|
|
);
|
|
expect(resolver.getVariant('otherFlag' as IFlagKey)).toStrictEqual(
|
|
getDefaultVariant(),
|
|
);
|
|
expect(resolver.getVariant('extraFlag' as IFlagKey)).toStrictEqual(variant);
|
|
});
|
|
|
|
test('should expose an helper to get variant value', () => {
|
|
expect(
|
|
getVariantValue({
|
|
enabled: true,
|
|
name: 'variant-A',
|
|
}),
|
|
).toBe('variant-A');
|
|
|
|
expect(
|
|
getVariantValue({
|
|
enabled: true,
|
|
name: 'variant',
|
|
payload: {
|
|
type: PayloadType.STRING,
|
|
value: 'variant-B',
|
|
},
|
|
}),
|
|
).toBe('variant-B');
|
|
|
|
expect(
|
|
getVariantValue({
|
|
enabled: true,
|
|
name: 'variant',
|
|
payload: {
|
|
type: PayloadType.JSON,
|
|
value: `{"foo": "bar"}`,
|
|
},
|
|
}),
|
|
).toStrictEqual({
|
|
foo: 'bar',
|
|
});
|
|
});
|