Gastón Fournier 4e0678dfb1 fix: allow empty appName as it may come in the url (#3953) ... ## About the changes Edit application under https://app.unleash-hosted.com/demo/applications/test-app is currently not working as the appName is expected to come in the request body, but it's actually part of the url. We have two options here: 1. We change the UI to adapt to the expectations of the request by adding appName to the request body (and eventually removing appName from the URL, which would be a breaking change) 2. We remove the restriction of only sending the appName in the body and take the one that comes in the URL. We have a validation that verifies that at least one of the two sets the appName ([here](e376088668/src/lib/services/client-metrics/instance-service.ts (L208)) we validate using [this schema](e376088668/src/lib/services/client-metrics/schema.ts (L55-L70))) In terms of REST API, we can assume that the appName will be present in the resource `/api/admin/metrics/applications` (an endpoint we don't have), but when we're updating an application we should refer to that application by its URL: `/api/admin/metrics/applications/<appName>` and the presence of an appName in the body might indicate that we're trying to change the name of the application (something we currently not support) Based on the above, I believe going with the second option is best, as it adheres to REST principles and does not require a breaking change. Despite that, we only support updating applications as the creation is done from metrics ingestion Fixes: #3580		2023-06-12 10:15:00 +02:00
..
admin	fix: add createdAt in projects API response (#3929)	2023-06-09 14:18:38 +00:00
auth	fix: remove consecutive slashes (#3882)	2023-05-27 16:16:51 +00:00
client	fix: move application logic to service (#3846)	2023-05-23 16:41:52 +02:00
openapi	fix: allow empty appName as it may come in the url (#3953)	2023-06-12 10:15:00 +02:00
proxy	Feat: enable toggle dialog (#3686)	2023-05-08 11:42:26 +03:00