1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-31 00:16:47 +01:00
unleash.unleash/src/lib
Nuno Góis c0bcc50b28
fix: add confirmation to disable password login (#3829)
https://linear.app/unleash/issue/2-1071/prevent-users-from-disabling-password-authentication-when-there-are-no

Improves the behavior of disabling password based login by adding some
relevant information and a confirmation dialog with a warning. This felt
better than trying to disable the toggle, by still allowing the end
users to make the decision, except now it should be a properly informed
decision with confirmation.


![image](https://github.com/Unleash/unleash/assets/14320932/2ca754d8-cfa2-4fda-984d-0c34b89750f3)

- **Password based administrators**: Admin accounts that have a password
set;
- **Other administrators**: Other admin users that do not have a
password. May be SSO, but may also be users that did not set a password
yet;
- **Admin service accounts**: Service accounts that have the admin root
role. Depending on how you're using the SA this may not necessarily mean
locking yourself out of an admin account, especially if you secured its
token beforehand;
- **Admin API tokens**: Similar to the above. If you secured an admin
API token beforehand, you still have access to all features through the
API;

Each one of them link to the respective page inside Unleash (e.g. users
page, service accounts page, tokens page...);

If you try to disable and press "save", and only in that scenario, you
are presented with the following confirmation dialog:


![image](https://github.com/Unleash/unleash/assets/14320932/5ad6d105-ad47-4d31-a1df-04737aed4e00)
2023-05-23 15:56:34 +01:00
..
__snapshots__ feat: disable bulk update env var (#3828) 2023-05-22 13:12:45 +00:00
addons Detailed slack notifications on feature toggle update (#3155) 2023-02-27 09:56:56 +00:00
db fix: add confirmation to disable password login (#3829) 2023-05-23 15:56:34 +01:00
domain/project-health Project health tests (#3028) 2023-02-02 12:01:16 +01:00
error fix: add missing options parameter back in (#3770) 2023-05-15 07:19:55 +00:00
features feat: improve frontend config freshness to < 1s (#3749) 2023-05-12 17:52:11 +00:00
middleware Clean up old errors (#3633) 2023-05-11 11:10:57 +02:00
openapi fix: add confirmation to disable password login (#3829) 2023-05-23 15:56:34 +01:00
proxy feat: improve frontend config freshness to < 1s (#3749) 2023-05-12 17:52:11 +00:00
routes fix: add confirmation to disable password login (#3829) 2023-05-23 15:56:34 +01:00
schema chore: deprecate username on api-tokens (#3616) 2023-05-04 09:56:00 +02:00
segments chore: add additional methods we want exposed (#3771) 2023-05-15 10:23:28 +00:00
services fix: add confirmation to disable password login (#3829) 2023-05-23 15:56:34 +01:00
types fix: add confirmation to disable password login (#3829) 2023-05-23 15:56:34 +01:00
util fix: properly handle flag resolver variants (#3808) 2023-05-18 17:04:55 +01:00
app.test.ts feat: add support for cdnPrefix for static assets (#1191) 2022-01-06 10:31:00 +01:00
app.ts Clean up old errors (#3633) 2023-05-11 11:10:57 +02:00
create-config.test.ts chore: remove optimal 304 flag (#3665) 2023-05-05 09:18:04 +02:00
create-config.ts feat: improve frontend config freshness to < 1s (#3749) 2023-05-12 17:52:11 +00:00
default-custom-auth-deny-all.ts refactor: move docs into new structure / fix links for SEO (#2416) 2022-11-22 09:05:30 +00:00
internals.ts chore: drop event hook (#3565) 2023-04-21 09:44:18 +02:00
logger.test.ts
logger.ts
metric-events.ts
metrics.test.ts chore: add linter rules for regexp (#3500) 2023-04-17 07:11:22 +00:00
metrics.ts Poc: calculate etag based on query and latest revison id (#3062) 2023-03-17 14:10:21 +01:00
server-impl.test.ts chore: drop event hook (#3565) 2023-04-21 09:44:18 +02:00
server-impl.ts Feat: project default strategy (#3644) 2023-04-28 14:59:04 +03:00