1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
unleash.unleash/frontend
Gastón Fournier 29be130757
fix: enforce weight precision to 1 decimal (#2749)
## About the changes
According to our docs, we only support up to 1 decimal place for
weights. This is to use integers to represent the percentages (we divide
them by 10) and supporting more decimals results in bad maths due to
floating point arithmetics.

This PRs adds Frontend and Backend validations to enforce this
restriction

Closes #2222

## Discussion points
Should we reconsider supporting more decimal places, that door remains
open, but for now we'll just adhere to our documentation because that
change would require some development.
2023-01-05 12:39:18 +01:00
..
cypress Remove full width access tab (#2679) 2022-12-13 13:41:40 +02:00
public
src fix: enforce weight precision to 1 decimal (#2749) 2023-01-05 12:39:18 +01:00
.editorconfig
.gitignore
.nvmrc chore(deps): update node.js to v14.21.1 (#2385) 2022-11-10 15:58:42 +01:00
.prettierignore Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
.prettierrc
cypress.json
index.html ui flags replaced in index.html (#2617) 2022-12-07 14:31:27 +02:00
index.js
orval.config.js Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
package.json Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
README.md
tsconfig.json
tsconfig.node.json Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
vercel.json fix: update vercel proxy paths (#2623) 2022-12-07 13:00:51 +01:00
vite.config.ts fix: allow import @server (#2601) 2022-12-05 16:21:59 +00:00
yarn.lock Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00

frontend

This directory contains the Unleash Admin UI frontend app.

Run with a local instance of the unleash-api

First, start the unleash-api backend on port 4242. Then, start the frontend dev server:

cd ~/frontend
yarn install
yarn run start

Run with a sandbox instance of the Unleash API

Alternatively, instead of running unleash-api on localhost, you can use a remote instance:

cd ~/frontend
yarn install
yarn run start:sandbox

Running end-to-end tests

We have a set of Cypress tests that run on the build before a PR can be merged so it's important that you check these yourself before submitting a PR. On the server the tests will run against the deployed Heroku app so this is what you probably want to test against:

yarn run start:sandbox

In a different shell, you can run the tests themselves:

yarn run e2e:heroku

If you need to test against patches against a local server instance, you'll need to run that, and then run the end to end tests using:

yarn run e2e

You may also need to test that a feature works against the enterprise version of unleash. Assuming the Heroku instance is still running, this can be done by:

yarn run start:enterprise
yarn run e2e

Generating the OpenAPI client

The frontend uses an OpenAPI client generated from the backend's OpenAPI spec. Whenever there are changes to the backend API, the client should be regenerated:

./scripts/generate-openapi.sh

This script assumes that you have a running instance of the enterprise backend at http://localhost:4242. The new OpenAPI client will be generated from the runtime schema of this instance. The target URL can be changed by setting the UNLEASH_OPENAPI_URL env var.