Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity
646a8f0192
unleash.unleash/frontend/src/component/executiveDashboard/componentsChart
History
Thomas Heartman c2015c6f33
fix: invalid HTML and react errors in insights pages (#6593) 
This PR fixes these errors (that were showing up in the dev console) in
the insights pages:
- nesting a div within a p in the count header (flags, environments,
apps); instead flip the relationship and nest the p within the div
- missing keys in mapped components
- passing a boolean "scrolled" value to the underlying component (a div)
is invalid: instead, make it so that that prop is not passed

The only one of these that could have a visual impact is the first one
(p>div -> div>p), but it appears to be the same to me.

Here's before the change:

![image](https://github.com/Unleash/unleash/assets/17786332/ffffd3cc-1236-458f-8449-3310b0044f14)



And here's after:

![image](https://github.com/Unleash/unleash/assets/17786332/9ad2d8f7-9f9e-492f-932e-a194683b1d75)
2024-03-18 15:25:03 +01:00
..
FlagsChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
FlagsProjectChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
MetricsSummaryChart fix: invalid HTML and react errors in insights pages (#6593) 2024-03-18 15:25:03 +01:00
ProjectHealthChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
TimeToProductionChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
UpdatesPerEnvironmentTypeChart fix: invalid HTML and react errors in insights pages (#6593) 2024-03-18 15:25:03 +01:00
UsersChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
UsersPerProjectChart chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00