mirror of
https://github.com/Unleash/unleash.git
synced 2025-09-10 17:53:36 +02:00
945e086f81
This PR adds the buttons (only UI, no functionality) to show either "all projects" or "my projects". The buttons use a styled button group and are hidden behind the new `projectListFilterMyProjects` flag. The button placement breaks with the previously established page header pattern of having all actions moved to the right. To accommodate this new placement, I created a new flex container in the header called `leftActions`, which is essentially just a mirror of the normal actions. I went with `leftActions` instead of `inlineStartActions` or something similar because I think it's clearer, and I don't see us adapting Unleash for different writing directions right now. We can always change it later. I have also slightly increased the end margin of the page header to accommodate the new designs and to adjust the spacing before the buttons. I adjusted the margin of the text instead of the padding of the left actions because this will keep the spacing to the page header the same on every page. Without it, we could end up in situations where the spacing changes from page to page based on whether it has left actions or not, which is probably undesirable.  ## Still to do: ### Hover colors ~~Find out what the right hover color variable is. I'm using the light mode hover color for now, which works well in both light and dark modes (looks nice and is AAccessible), but it's not the same as the hover color for other buttons in dark mode.~~ Fixed ☝🏼 ### Small windows Also worth noting: at around 500px, the layout shift starts to cause problems and we end up with overlapping elements. How do we want to deal with narrower screens? Today, the UI is pretty functional until we reach about 250px. It would be nice to not increase that size. The new version breaking at about 500px:  The old version breaking at about 250px:  ### Margins We also need to figure out how much space we want on smaller windows:  |
||
|---|---|---|
| .. | ||
| CreateTagType | ||
| EditTagType | ||
| TagTypeForm | ||
| TagTypeList | ||