1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
unleash.unleash/.github
Gastón Fournier acecffd93f
fix: force languages in cypress browser for tests (#8049)
To fix this we had to create a free trial account on cypress and enable
the recording of the test. That way we found out the issue was with a
locale:
![image
(38)](https://github.com/user-attachments/assets/db2fad23-6fec-47c0-8c6f-a93f3e4e4c4c)

Probably, this works well locally because our local machines do have a
default locale, but probably we don't have one when running in CI, and
millify library is causing the tests to fail specifically at this line:
363911c4a1/frontend/src/component/common/AvatarGroup/AvatarGroup.tsx (L89)
(validated
[here](https://github.com/Unleash/unleash/pull/8040/files#diff-afc857890da2221bd34feed0ff45dd7745ff32fb0b27055214cbe69896d5311dL89)).

Unfortunately, upgrading millify didn't help, but downgrading to v5
(which doesn't support locales), solve the issue at the cost of not
having the up-to-date library:
https://github.com/Unleash/unleash/pull/8048

I believe the issue is related to this locale `c` reported here:
https://github.com/cypress-io/cypress/issues/7890#issuecomment-2105991364
because only after overriding the languages this worked
2024-09-03 10:06:58 +00:00
..
ext-logos
workflows fix: force languages in cypress browser for tests (#8049) 2024-09-03 10:06:58 +00:00
dashboard.png
deploy-digital.svg
deploy-heroku-20.png fix: styles to docs 2021-06-05 00:25:35 +02:00
FUNDING.yml
github_header_opaque_landscape.svg chore: update unleash banner in readme (#7178) 2024-05-28 10:42:17 +03:00
github_online_demo.svg
github_unleash_users.svg fix: Add unleash users image 2022-04-08 13:19:24 +02:00
Logo_DarkBlue_Transparent_Portrait.png
Logo_DarkBlue_Transparent_Portrait.svg
logo.png
stale.yml
Unleash_architecture.svg
unleash-logo.svg