mirror of
https://github.com/Unleash/unleash.git
synced 2025-09-10 17:53:36 +02:00
https://linear.app/unleash/issue/2-1165/improve-adminalert-usage-to-be-more-generic-accept-non-admin Upgrades our `AdminAlert` to a new `PermissionGuard`. **Question**: We don't **need** to, but **should** we be specific about the `ADMIN` permission every time? Technically `PermissionGuard` could have `permissions` as optional and assume `[]` by default, which will add `ADMIN` anyways. However, I feel like we may gain some readability if we're specific about it. WDYT? Single permission:  Multiple permissions: 
12 lines
363 B
TypeScript
12 lines
363 B
TypeScript
import InvoiceList from './InvoiceList';
|
|
import { ADMIN } from 'component/providers/AccessProvider/permissions';
|
|
import { PermissionGuard } from 'component/common/PermissionGuard/PermissionGuard';
|
|
|
|
export const InvoiceAdminPage = () => (
|
|
<div>
|
|
<PermissionGuard permissions={ADMIN}>
|
|
<InvoiceList />
|
|
</PermissionGuard>
|
|
</div>
|
|
);
|