mirror of
https://github.com/Unleash/unleash.git
synced 2024-12-22 19:07:54 +01:00
95a0c7748f
https://linear.app/unleash/issue/2-1165/improve-adminalert-usage-to-be-more-generic-accept-non-admin Upgrades our `AdminAlert` to a new `PermissionGuard`. **Question**: We don't **need** to, but **should** we be specific about the `ADMIN` permission every time? Technically `PermissionGuard` could have `permissions` as optional and assume `[]` by default, which will add `ADMIN` anyways. However, I feel like we may gain some readability if we're specific about it. WDYT? Single permission: ![image](https://github.com/Unleash/unleash/assets/14320932/eab414ae-e798-4ab6-ba96-cde2977dc98b) Multiple permissions: ![image](https://github.com/Unleash/unleash/assets/14320932/25302442-8fcc-4aa1-9525-d54f5f9350af) |
||
---|---|---|
.. | ||
__mocks__ | ||
assets | ||
component | ||
constants | ||
contexts | ||
hooks | ||
interfaces | ||
openapi | ||
themes | ||
types | ||
utils | ||
index.tsx | ||
setupTests.ts | ||
vite-env.d.ts |