1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-06 00:07:44 +01:00
unleash.unleash/frontend/src/component
Thomas Heartman c2015c6f33
fix: invalid HTML and react errors in insights pages (#6593)
This PR fixes these errors (that were showing up in the dev console) in
the insights pages:
- nesting a div within a p in the count header (flags, environments,
apps); instead flip the relationship and nest the p within the div
- missing keys in mapped components
- passing a boolean "scrolled" value to the underlying component (a div)
is invalid: instead, make it so that that prop is not passed

The only one of these that could have a visual impact is the first one
(p>div -> div>p), but it appears to be the same to me.

Here's before the change:

![image](https://github.com/Unleash/unleash/assets/17786332/ffffd3cc-1236-458f-8449-3310b0044f14)



And here's after:

![image](https://github.com/Unleash/unleash/assets/17786332/9ad2d8f7-9f9e-492f-932e-a194683b1d75)
2024-03-18 15:25:03 +01:00
..
accessOverview
admin chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
application chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
archive chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
banners chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
changeRequest chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
common chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
context chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
demo chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
environments chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
events chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
executiveDashboard fix: invalid HTML and react errors in insights pages (#6593) 2024-03-18 15:25:03 +01:00
feature chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
featureTypes chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
feedback chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
feedbackNew chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
filter chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
integrations chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
layout chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
loginHistory chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
maintenance
menu chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
playground/Playground chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
project feat: lead time for changes (#6592) 2024-03-18 16:22:06 +02:00
providers chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
segments chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
signals chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
splash chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
strategies chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
tags chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
user chore: Bump biome and configure husky (#6589) 2024-03-18 13:58:05 +01:00
App.tsx feat: making banner more composable (#6540) 2024-03-13 16:21:40 +01:00
InitialRedirect.tsx