mirror of
https://github.com/Unleash/unleash.git
synced 2025-10-13 11:17:26 +02:00
d2e2378481
Adds a timestamp for each state we have time (and that isn't a state downstream from the current state) in the CR timeline. <img width="437" height="318" alt="image" src="https://github.com/user-attachments/assets/a499e73f-c506-46a0-8d1a-7e4eb5ec4f7d" /> The timestamp respects the user's preferred locale and uses the `time` element. I've used the current name of the API payload's timestamps as it stands on the enterprise main branch for now. This name is not set in any schemas yet, so it is likely to change. Because it's not currently exposed to any users, that will not cause any issues. Name suggestions are welcome if you have them. We only show timestamps for states up to and including the current state. Timestamps for downstream states (such as "approved" if you're in the "in review" state), will not be shown, even if they exist in the payload. (There are some decisions to make on whether to include these in the payload at all or not.) There's no flags in this PR. They're not necessary If the API payload doesn't contain the timestamp, we just don't render the timestamp, and the timeline looks the way it always did: <img width="447" height="399" alt="image" src="https://github.com/user-attachments/assets/0062393a-190c-4099-bc16-29f9da82e7ea" /> ## Bonus work In the `ChangeRequestTimeline.tsx` file, I've made a few extra changes: - `createTimelineItem` and `createScheduledTimelineItem` have become normal React components (`TimelineItem` and `ScheduledTimelineItem`) and are being called as such (in accordance with [React recommendations](https://react.dev/reference/rules/react-calls-components-and-hooks#never-call-component-functions-directly)). - I've updated the subtitles for schedules to also use the time element, to improve HTML structure. ## Outstanding work There's a few things that still need to be sorted out (primarily with UX). Mainly about how we handle scheduled items, which already have time information. For now, it looks like this: <img width="426" height="394" alt="image" src="https://github.com/user-attachments/assets/4bfc4ca2-c738-4954-9251-8d063143371e" /> <img width="700" height="246" alt="image" src="https://github.com/user-attachments/assets/fe688b08-c5c8-40f8-a9d0-fe455e44665f" /> |
||
|---|---|---|
| .. | ||
| admin | ||
| application | ||
| archive | ||
| banners | ||
| changeRequest | ||
| commandBar | ||
| common | ||
| context | ||
| counters/ExploreCounters | ||
| demo | ||
| environments | ||
| events | ||
| feature | ||
| featureTypes | ||
| feedback | ||
| feedbackNew | ||
| filter | ||
| impact-metrics | ||
| insights | ||
| integrations | ||
| layout | ||
| loginHistory | ||
| maintenance | ||
| menu | ||
| onboarding | ||
| personalDashboard | ||
| playground/Playground | ||
| project | ||
| providers | ||
| releases | ||
| segments | ||
| signals | ||
| splash | ||
| strategies | ||
| tags | ||
| unknownFlags | ||
| user | ||
| App.tsx | ||
| InitialRedirect.tsx | ||