mirror of
https://github.com/Unleash/unleash.git
synced 2024-11-01 19:07:38 +01:00
7ce5b3de64
Adding stricter types to `FlagResolver` can possibly help improve our DX - Help us prevent errors like typos, guide us to correctly add a flag when needed, and warn us of stray checks whenever we do a clean up at a later stage.
102 lines
2.7 KiB
TypeScript
102 lines
2.7 KiB
TypeScript
import { defaultExperimentalOptions, IFlagKey } from '../types/experimental';
|
|
import FlagResolver from './flag-resolver';
|
|
import { IExperimentalOptions } from '../types/experimental';
|
|
|
|
test('should produce empty exposed flags', () => {
|
|
const resolver = new FlagResolver(defaultExperimentalOptions);
|
|
|
|
const result = resolver.getAll();
|
|
|
|
expect(result.ENABLE_DARK_MODE_SUPPORT).toBe(false);
|
|
});
|
|
|
|
test('should produce UI flags with extra dynamic flags', () => {
|
|
const config = {
|
|
...defaultExperimentalOptions,
|
|
flags: { extraFlag: false },
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.extraFlag).toBe(false);
|
|
});
|
|
|
|
test('should use external resolver for dynamic flags', () => {
|
|
const externalResolver = {
|
|
isEnabled: (name: string) => {
|
|
if (name === 'extraFlag') {
|
|
return true;
|
|
}
|
|
},
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.extraFlag).toBe(true);
|
|
});
|
|
|
|
test('should not use external resolver for enabled experiments', () => {
|
|
const externalResolver = {
|
|
isEnabled: () => {
|
|
return false;
|
|
},
|
|
};
|
|
|
|
const config = {
|
|
flags: { should_be_enabled: true, extraFlag: false },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
const result = resolver.getAll() as typeof config.flags;
|
|
|
|
expect(result.should_be_enabled).toBe(true);
|
|
});
|
|
|
|
test('should load experimental flags', () => {
|
|
const externalResolver = {
|
|
isEnabled: () => {
|
|
return false;
|
|
},
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false, someFlag: true },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
expect(resolver.isEnabled('someFlag' as IFlagKey)).toBe(true);
|
|
expect(resolver.isEnabled('extraFlag' as IFlagKey)).toBe(false);
|
|
});
|
|
|
|
test('should load experimental flags from external provider', () => {
|
|
const externalResolver = {
|
|
isEnabled: (name: string) => {
|
|
if (name === 'extraFlag') {
|
|
return true;
|
|
}
|
|
},
|
|
};
|
|
|
|
const config = {
|
|
flags: { extraFlag: false, someFlag: true },
|
|
externalResolver,
|
|
};
|
|
|
|
const resolver = new FlagResolver(config as IExperimentalOptions);
|
|
|
|
expect(resolver.isEnabled('someFlag' as IFlagKey)).toBe(true);
|
|
expect(resolver.isEnabled('extraFlag' as IFlagKey)).toBe(true);
|
|
});
|