mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-31 00:16:47 +01:00
2bad98a121
This PR fixes how Unleash handles tag values. Specifically, it does these things: 1. Trims leading and trailing whitespace from tag values before inserting them into the database 2. Updates OpenAPI validation to not allow whitespace-only and to ignore leading and trailing whitespace Additionally, it moves the tag length constants into the constants file from the Joi tag schema file. This is because importing the values previously rendered them as undefined (probably due to a circular dependency somewhere in the system). This means that the previous values were also ignored by OpenAPI. UI updates reflecting this wil follow. ## Background When you tag a flag, there's nothing stopping you from using an entirely empty tag or a tag with leading/trailing whitespace. Empty tags make little sense and leading trailing whitespace differences are incredibly subtle:  Additionally, leading and trailing whitespace is not shown in the dropdown list, so you'd have to guess at which is the right one. 
71 lines
1.9 KiB
TypeScript
71 lines
1.9 KiB
TypeScript
export const DEFAULT_ENV = 'default';
|
|
|
|
export const ALL_PROJECTS = '*';
|
|
export const ALL_ENVS = '*';
|
|
|
|
export const URL_SAFE_BASIC = /^[a-z0-9\-_]*$/;
|
|
|
|
export const ROOT_PERMISSION_TYPE = 'root';
|
|
export const ENVIRONMENT_PERMISSION_TYPE = 'environment';
|
|
export const PROJECT_PERMISSION_TYPE = 'project';
|
|
|
|
export const ROOT_ROLE_TYPE = 'root';
|
|
export const PROJECT_ROLE_TYPE = 'project';
|
|
export const CUSTOM_ROOT_ROLE_TYPE = 'root-custom';
|
|
export const CUSTOM_PROJECT_ROLE_TYPE = 'custom';
|
|
export const PREDEFINED_ROLE_TYPES = [ROOT_ROLE_TYPE, PROJECT_ROLE_TYPE];
|
|
export const ROOT_ROLE_TYPES = [ROOT_ROLE_TYPE, CUSTOM_ROOT_ROLE_TYPE];
|
|
export const PROJECT_ROLE_TYPES = [PROJECT_ROLE_TYPE, CUSTOM_PROJECT_ROLE_TYPE];
|
|
|
|
export const TAG_MIN_LENGTH = 2;
|
|
export const TAG_MAX_LENGTH = 50;
|
|
|
|
/* CONTEXT FIELD OPERATORS */
|
|
|
|
export const NOT_IN = 'NOT_IN';
|
|
export const IN = 'IN';
|
|
export const STR_ENDS_WITH = 'STR_ENDS_WITH';
|
|
export const STR_STARTS_WITH = 'STR_STARTS_WITH';
|
|
export const STR_CONTAINS = 'STR_CONTAINS';
|
|
export const NUM_EQ = 'NUM_EQ';
|
|
export const NUM_GT = 'NUM_GT';
|
|
export const NUM_GTE = 'NUM_GTE';
|
|
export const NUM_LT = 'NUM_LT';
|
|
export const NUM_LTE = 'NUM_LTE';
|
|
export const DATE_AFTER = 'DATE_AFTER';
|
|
export const DATE_BEFORE = 'DATE_BEFORE';
|
|
export const SEMVER_EQ = 'SEMVER_EQ';
|
|
export const SEMVER_GT = 'SEMVER_GT';
|
|
export const SEMVER_LT = 'SEMVER_LT';
|
|
|
|
export const ALL_OPERATORS = [
|
|
NOT_IN,
|
|
IN,
|
|
STR_ENDS_WITH,
|
|
STR_STARTS_WITH,
|
|
STR_CONTAINS,
|
|
NUM_EQ,
|
|
NUM_GT,
|
|
NUM_GTE,
|
|
NUM_LT,
|
|
NUM_LTE,
|
|
DATE_AFTER,
|
|
DATE_BEFORE,
|
|
SEMVER_EQ,
|
|
SEMVER_GT,
|
|
SEMVER_LT,
|
|
] as const;
|
|
|
|
export const STRING_OPERATORS = [
|
|
STR_ENDS_WITH,
|
|
STR_STARTS_WITH,
|
|
STR_CONTAINS,
|
|
IN,
|
|
NOT_IN,
|
|
];
|
|
export const NUM_OPERATORS = [NUM_EQ, NUM_GT, NUM_GTE, NUM_LT, NUM_LTE];
|
|
export const DATE_OPERATORS = [DATE_AFTER, DATE_BEFORE];
|
|
export const SEMVER_OPERATORS = [SEMVER_EQ, SEMVER_GT, SEMVER_LT];
|
|
|
|
export const PAT_LIMIT = 10;
|