mirror of
https://github.com/Unleash/unleash.git
synced 2025-05-31 01:16:01 +02:00
5417662f5a
This PR adds a 'change-request-conflict-created' event whenever someone
save a strategy update for a strategy that's used in either pending or
scheduled change requests.
Data for pending change requests will only be sent if change requests
are enabled. Data for scheduled change requests will be sent regardless.
Getting this data is somewhat involved, so I've extracted as much of the
logic into a separate file as possible.
The event re-uses the existing `change_request` metric and sends the
following data for each change request that we discover conflicts on:
```ts
{
state: ChangeRequestState,
changeRequest: string, // <unleash identifier>#<change request id>
action: 'edit-strategy',
eventType: 'conflict-created'
}
```
There's only one action for this for now, but we could expand this event
to things such as strategy deletion, feature archival, in the future.
That said, I'd be happy to take it out.
## Discussion points
### Has the strategy actually been updated?
This does not check whether a strategy has actually changed before
emitting the event, only that you save your strategy changes.
This assumes that most people will simply close the modal by
clicking/tapping outside it or using the escape key instead of pressing
save.
However, it will likely lead to some false positives. If we think that
is an issue, I would suggest adding a check that something in the
strategy has actually changed in a follow-up PR.
|
||
|---|---|---|
| .. | ||
| apiUtils.ts | ||
| arraysHaveSameItems.test.ts | ||
| arraysHaveSameItems.ts | ||
| calculatePercentage.ts | ||
| capitalizeFirst.ts | ||
| cleanConstraint.test.ts | ||
| cleanConstraint.ts | ||
| createFeatureStrategy.test.ts | ||
| createFeatureStrategy.ts | ||
| createLocalStorage.ts | ||
| cyclicIterator.test.ts | ||
| cyclicIterator.ts | ||
| deepOmit.test.ts | ||
| deepOmit.ts | ||
| env.test.ts | ||
| env.ts | ||
| formatAccessText.test.ts | ||
| formatAccessText.ts | ||
| formatConstraintValue.ts | ||
| formatDate.ts | ||
| formatPath.test.ts | ||
| formatPath.ts | ||
| formatUnknownError.test.ts | ||
| formatUnknownError.ts | ||
| getFeatureMetrics.ts | ||
| getFeatureTypeIcons.ts | ||
| instanceTrial.test.ts | ||
| instanceTrial.ts | ||
| nonEmptyArray.ts | ||
| objectId.test.ts | ||
| objectId.ts | ||
| oneOf.ts | ||
| operatorsForContext.ts | ||
| paginate.test.ts | ||
| paginate.ts | ||
| parseParameter.test.ts | ||
| parseParameter.ts | ||
| permissions.ts | ||
| projectFilterGenerator.ts | ||
| removeEmptyStringFields.test.ts | ||
| removeEmptyStringFields.ts | ||
| reorderObject.test.ts | ||
| reorderObject.ts | ||
| routePathHelpers.ts | ||
| search.ts | ||
| serializeQueryParams.ts | ||
| sortStrategyParameters.test.ts | ||
| sortStrategyParameters.ts | ||
| sortTypes.test.ts | ||
| sortTypes.ts | ||
| storage.test.ts | ||
| storage.ts | ||
| strategyNames.tsx | ||
| testIds.ts | ||
| testRenderer.tsx | ||
| testServer.ts | ||
| unique-change-request-id.ts | ||
| unknownify.ts | ||
| validateParameterValue.test.ts | ||
| validateParameterValue.ts | ||
| variants.ts | ||
| withTableState.test.tsx | ||
| withTableState.ts | ||