mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2026-02-01 20:10:35 +01:00
[V2] feat(sign): add SVG support for signature image uploads (#5279)
# Description of Changes This pull request updates the `ImageUploader` component to improve SVG file support. The main changes ensure that SVG files can be uploaded and are properly validated, even if their MIME type is not set as an image. **SVG File Support Improvements:** * Updated the file type validation in the `handleImageChange` function to allow files ending with `.svg`, even if their MIME type is not `image/*`. * Modified the `accept` attribute in the `FileInput` component to explicitly include `.svg` files, making SVG selection possible in the file picker. ### Sign with SVG pics <img width="1920" height="998" alt="image" src="https://github.com/user-attachments/assets/9e24d83e-304c-4c7b-85b3-82798616ac5a" /> <!-- Please provide a summary of the changes, including: - What was changed - Why the change was made - Any challenges encountered Closes #(issue_number) --> --- ## Checklist ### General - [ ] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [ ] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [ ] I have performed a self-review of my own code - [ ] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details. Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
This commit is contained in:
parent
738dd0645d
commit
34fd328444
@ -23,9 +23,9 @@ export const ImageUploader: React.FC<ImageUploaderProps> = ({
|
||||
const handleImageChange = async (file: File | null) => {
|
||||
if (file && !disabled) {
|
||||
try {
|
||||
// Validate that it's actually an image file
|
||||
if (!file.type.startsWith('image/')) {
|
||||
console.error('Selected file is not an image');
|
||||
// Validate that it's actually an image file or SVG
|
||||
if (!file.type.startsWith('image/') && !file.name.toLowerCase().endsWith('.svg')) {
|
||||
console.error('Selected file is not an image or SVG');
|
||||
return;
|
||||
}
|
||||
|
||||
@ -45,7 +45,7 @@ export const ImageUploader: React.FC<ImageUploaderProps> = ({
|
||||
<FileInput
|
||||
label={label}
|
||||
placeholder={placeholder || t('sign.image.placeholder', 'Select image file')}
|
||||
accept="image/*"
|
||||
accept="image/*,.svg"
|
||||
onChange={handleImageChange}
|
||||
disabled={disabled}
|
||||
/>
|
||||
|
||||
Loading…
Reference in New Issue
Block a user