mirror of
https://github.com/Frooodle/Stirling-PDF.git
synced 2025-12-18 20:04:17 +01:00
ci: simplify docker-compose test workflow conditions (#4989)
# Description of Changes This pull request simplifies the workflow logic for the `docker-compose-tests` job in `.github/workflows/build.yml`. ### What was changed - Removed the extended conditional logic that depended on the results of the `test-build-docker-images` job. - Updated the `needs` configuration so that `docker-compose-tests` depends solely on `files-changed`. ### Why the change was made The previous logic attempted to optimize execution flow but introduced unnecessary complexity and conditional branches. By simplifying the workflow: - Job relationships become easier to understand and maintain. - The workflow executes more predictably. - The dependency graph becomes clearer, reducing potential misfires caused by mixed job states. --- ## Checklist ### General - [x] I have read the [Contribution Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md) - [x] I have read the [Stirling-PDF Developer Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md) (if applicable) - [ ] I have read the [How to add new languages to Stirling-PDF](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md) (if applicable) - [x] I have performed a self-review of my own code - [x] My changes generate no new warnings ### Documentation - [ ] I have updated relevant docs on [Stirling-PDF's doc repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/) (if functionality has heavily changed) - [ ] I have read the section [Add New Translation Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/HowToAddNewLanguage.md#add-new-translation-tags) (for new translation tags only) ### Translations (if applicable) - [ ] I ran [`scripts/counter_translation.py`](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/docs/counter_translation.md) ### UI Changes (if applicable) - [ ] Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR) ### Testing (if applicable) - [ ] I have tested my changes locally. Refer to the [Testing Guide](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/devGuide/DeveloperGuide.md#6-testing) for more details.
This commit is contained in:
parent
97f3b88222
commit
af2e418129
10
.github/workflows/build.yml
vendored
10
.github/workflows/build.yml
vendored
@ -204,14 +204,8 @@ jobs:
|
||||
retention-days: 3
|
||||
|
||||
docker-compose-tests:
|
||||
if: |
|
||||
needs.files-changed.outputs.project == 'true' &&
|
||||
(
|
||||
needs.files-changed.outputs.docker != 'true' ||
|
||||
needs.test-build-docker-images.result == 'success' ||
|
||||
needs.test-build-docker-images.result == 'skipped'
|
||||
)
|
||||
needs: [files-changed, test-build-docker-images]
|
||||
if: needs.files-changed.outputs.project == 'true'
|
||||
needs: files-changed
|
||||
# if: github.event_name == 'push' && github.ref == 'refs/heads/main' ||
|
||||
# (github.event_name == 'pull_request' &&
|
||||
# contains(github.event.pull_request.labels.*.name, 'licenses') == false &&
|
||||
|
||||
Loading…
Reference in New Issue
Block a user