Close modal nicely

Remove warnings
This commit is contained in:
Connor Yoh 2025-10-15 16:27:17 +01:00
parent 3fbcf96546
commit e3bebc83c0
5 changed files with 13 additions and 10 deletions

View File

@ -2,15 +2,17 @@ import { Modal, Stack, Button, Text, Title, Anchor } from '@mantine/core';
import { useTranslation } from 'react-i18next';
import { useState } from 'react';
import { Z_ANALYTICS_MODAL } from '../../styles/zIndex';
import { useAppConfig } from '../../contexts/AppConfigContext';
import apiClient from '../../services/apiClient';
interface AdminAnalyticsChoiceModalProps {
opened: boolean;
onClose?: () => void;
onClose: () => void;
}
export default function AdminAnalyticsChoiceModal({ opened }: AdminAnalyticsChoiceModalProps) {
export default function AdminAnalyticsChoiceModal({ opened, onClose }: AdminAnalyticsChoiceModalProps) {
const { t } = useTranslation();
const { refetch } = useAppConfig();
const [loading, setLoading] = useState(false);
const [error, setError] = useState<string | null>(null);
@ -19,14 +21,16 @@ export default function AdminAnalyticsChoiceModal({ opened }: AdminAnalyticsChoi
setError(null);
try {
const formData = new FormData();
const formData = new FormData();
formData.append('enabled', enableAnalytics.toString());
await apiClient.post('/api/v1/settings/update-enable-analytics', formData);
// Refetch config to apply new settings without page reload
await refetch();
// Reload the page to apply new settings
window.location.reload();
// Close the modal after successful save
onClose();
} catch (err) {
setError(err instanceof Error ? err.message : 'Unknown error occurred');
setLoading(false);

View File

@ -60,7 +60,6 @@ export const AppConfigProvider: React.FC<{ children: React.ReactNode }> = ({ chi
const data: AppConfig = await response.json();
setConfig(data);
console.warn('[AppConfig] Fetched app config:', data);
} catch (err) {
const errorMessage = err instanceof Error ? err.message : 'Unknown error occurred';
setError(errorMessage);

View File

@ -19,7 +19,6 @@ export function useScarfTracking() {
// Update scarf config whenever config or consent changes
useEffect(() => {
console.warn('[useScarfTracking] Updating scarf config:', { enableScarf: config?.enableScarf, isServiceAccepted });
if (config && config.enableScarf !== undefined) {
setScarfConfig(config.enableScarf, isServiceAccepted);
}

View File

@ -162,7 +162,10 @@ export default function HomePage() {
return (
<div className="h-screen overflow-hidden">
<AdminAnalyticsChoiceModal opened={showAnalyticsModal} />
<AdminAnalyticsChoiceModal
opened={showAnalyticsModal}
onClose={() => setShowAnalyticsModal(false)}
/>
<ToolPanelModePrompt />
{isMobile ? (
<div className="mobile-layout">

View File

@ -46,7 +46,6 @@ export function setScarfConfig(
* @param pathname - The pathname to track (usually window.location.pathname)
*/
export function firePixel(pathname: string): void {
console.warn('[scarfTracking]Firing with Current config:', { enableScarf, isServiceAccepted });
// Dev-mode warning if called before initialization
if (!configured) {
console.warn(
@ -82,7 +81,6 @@ export function firePixel(pathname: string): void {
const img = new Image();
img.referrerPolicy = "no-referrer-when-downgrade";
img.src = url;
console.warn('[scarfTracking] Firing pixel for', pathname);
}
/**