mirror of https://github.com/Frooodle/Stirling-PDF.git synced 2025-01-19 00:07:17 +01:00

expand: check language properties (#2724 )

# Description

Improvement in `check_language_properties.py`:

Added support for local Windows commands to check language properties
files with an updated script.
Added a new optional argument `--check-file` to specify a single file to
check, replacing the need to process all files in the directory.
Adjusted file path handling to better support Windows paths.

Update to `update-translations.yml`:

Added `workflow_dispatch` trigger to allow manual execution of the
workflow.

Documentation update in `HowToAddNewLanguage.md`:

Added instructions for running the language properties check locally on
Windows, including example commands.
These changes streamline the process of checking language properties
files and provide additional flexibility for local testing and manual
workflow triggering.

## Checklist

- [x] I have read the [Contribution
Guidelines](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/CONTRIBUTING.md)
- [x] I have performed a self-review of my own code
- [ ] I have attached images of the change if it is UI based
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] If my code has heavily changed functionality I have updated
relevant docs on [Stirling-PDFs doc
repo](https://github.com/Stirling-Tools/Stirling-Tools.github.io/blob/main/docs/)
- [x] My changes generate no new warnings
- [ ] I have read the section [Add New Translation
Tags](https://github.com/Stirling-Tools/Stirling-PDF/blob/main/HowToAddNewLanguage.md#add-new-translation-tags)
(for new translation tags only)

2025-01-16 22:03:54 +00:00

3.7 KiB

Raw Blame History

Stirling-PDF

How to add new languages to Stirling-PDF

Fork Stirling-PDF and create a new branch out of main.

Then add a reference to the language in the navbar by adding a new language entry to the dropdown:

Edit the file: languages.html
Add a flag SVG file to: flags directory

Any SVG flags are fine; most of the current ones were sourced from here. If your language isn't represented by a flag, choose a similar one, such as Saudi Arabia's flag for Arabic.

For example, to add Polish, you would add:

<a class="dropdown-item lang_dropdown-item" href="" data-bs-language-code="pl_PL">
    <img src="images/flags/pl.svg" alt="icon" width="20" height="15"> Polski
</a>

The data-bs-language-code is the code used to reference the file in the next step.

Add Language Property File

Start by copying the existing English property file:

messages_en_GB.properties

Copy and rename it to messages_{your data-bs-language-code here}.properties. In the Polish example, you would set the name to messages_pl_PL.properties.

Then simply translate all property entries within that file and make a Pull Request (PR) into main for others to use!

If you do not have a Java IDE, I am happy to verify that the changes work once you raise the PR (but I won't be able to verify the translations themselves).

Handling Untranslatable Strings

Sometimes, certain strings in the properties file may not require translation because they are the same in the target language or are universal (like names of protocols, certain terminologies, etc.). To ensure accurate statistics for language progress, these strings should be added to the ignore_translation.toml file located in the scripts directory. This will exclude them from the translation progress calculations.

For example, if the English string error=Error does not need translation in Polish, add it to the ignore_translation.toml under the Polish section:

[pl_PL]
ignore = [
    "language.direction",  # Existing entries
    "error"                # Add new entries here
]

Add New Translation Tags

Important

If you add any new translation tags, they must first be added to the messages_en_GB.properties file. This ensures consistency across all language files.

New translation tags must be added to the messages_en_GB.properties file to maintain a reference for other languages.
After adding the new tags to messages_en_GB.properties, add and translate them in the respective language file (e.g., messages_pl_PL.properties).

Make sure to place the entry under the correct language section. This helps maintain the accuracy of translation progress statistics and ensures that the translation tool or scripts do not misinterpret the completion rate.

Use this code to perform a local check

Windows command

python .github/scripts/check_language_properties.py --reference-file src\main\resources\messages_en_GB.properties --branch "" --files src\main\resources\messages_pl_PL.properties

python .github/scripts/check_language_properties.py --reference-file src\main\resources\messages_en_GB.properties --branch "" --check-file src\main\resources\messages_pl_PL.properties

3.7 KiB Raw Blame History