Commit Graph

257 Commits

Author SHA1 Message Date
nevart
7c86fe1739 APT key: don't force and provide checksum, to fix check mode
As described in https://github.com/ansible/ansible/issues/65687, get_url
only partially supports check_mode: "the changed status will reflect
comparison to an empty source file".

Before this change, executing this code, with the key already being in
place on the target system, would report "OK", while check_mode would
report "changed".

Due to this change, both now either report "OK" or "changed", depending
on the state of the target system.
2023-06-26 07:34:10 +00:00
Jeff Geerling
a29e9d51e9 Fix Molecule CI workflow since docker plugin has moved. 2023-04-20 17:27:13 -05:00
Jeff Geerling
67e50e9af0
Merge pull request #394 from aurelien-bareille/master
Add flag to deactivate repository configuration
2023-02-02 21:28:43 -06:00
aurelien-bareille
61d571a941 Add documentation 2022-12-26 16:53:42 +01:00
aurelien-bareille
0ad2ddd2c6 Include repository setup dependancies in flag scope 2022-12-14 18:25:29 +01:00
aurelien-bareille
8b623b2266 Add flag to deactivate repository configuration 2022-12-14 16:31:46 +01:00
Jeff Geerling
b4a2ff5ee7 Remove CentOS 7 from tests. 2022-12-06 19:24:50 -06:00
Jeff Geerling
32dfe4c00e Fix Molecule CI workflow for Ubuntu 22.04 GitHub Actions. 2022-12-06 18:23:40 -06:00
Jeff Geerling
03d5bd6d06 Remove deprecated warn arg from command and shell module invocations. 2022-11-26 22:51:49 -06:00
Jeff Geerling
9685a2a30d
Merge pull request #389 from abalage/bugfix/fix-overriding-os-variables
Make override work by adjusting variable name to match defaults/main.yml
2022-11-10 16:01:59 -06:00
Balázs Németh
17ddd4ef2e Make override work by adjusting variable to match defaults/main.yml 2022-11-10 22:11:22 +01:00
Jeff Geerling
9154e3bf75
Merge pull request #384 from berthin/master
Fix condition for empty docker compose svn
2022-11-05 14:21:48 -05:00
berthin
3800fd2d42
Fix condition for empty docker compose svn 2022-11-05 11:20:04 +01:00
Jeff Geerling
96eaae30e5
Merge pull request #380 from adamantike/fix/set-docker_package-for-archlinux
Set default docker_package for Archlinux distribution
2022-10-10 15:49:02 -05:00
Michael Manganiello
8e09a22180 Set default docker_package for Archlinux distribution
Instead of the current role's default value for `docker_package`
(`docker-ce`), the package name for the Archlinux OS distribution is
`docker` [1].

Considerations:
* Filename is `Archlinux`, as that is the possible value exposed by
  Ansible, in `ansible_distribution` [2] and `ansible_os_family` [3].
* Platform name in meta's `galaxy_info` has been changed to `ArchLinux`,
  as that's the supported platform name in Ansible Galaxy [4].

[1] https://archlinux.org/packages/community/x86_64/docker/
[2] https://docs.ansible.com/ansible/2.6/user_guide/playbooks_conditionals.html#ansible-distribution
[3] https://docs.ansible.com/ansible/2.6/user_guide/playbooks_conditionals.html#ansible-os-family
[4] https://galaxy.ansible.com/api/v1/platforms/?name__icontains=arch
2022-10-09 23:01:52 -03:00
Jeff Geerling
a15de78905
Merge pull request #376 from geerlingguy/290-arm
Fixes #290: Allow role to work on ARM64 out of the box.
2022-09-26 17:15:32 -05:00
Jeff Geerling
53c487c31a Fixes #290: Allow role to work on ARM64 out of the box. 2022-09-26 17:09:27 -05:00
Jeff Geerling
6f636dc579
Merge pull request #373 from sosheskaz/fix-gpg
Download apt key directly
2022-09-08 17:34:14 -05:00
Jeff Geerling
928fe893e9 PR #370: Style cleanup. 2022-09-05 21:32:10 -05:00
Jeff Geerling
9f8ea35051
Merge pull request #370 from fardke/reset-ssh-connection-after-docker-install
reset ssh connection to allow user changes to affect current login user
2022-09-05 21:30:55 -05:00
Eric Miller
f463bb2c1a Download apt key directly
Fixes issue #372
2022-09-05 17:55:21 -05:00
Kevin Fardel
0884ae21b8 reset ssh connection to allow user changes to affect 'current login user'
Why:
Without this modification, we can't use docker with docker_users in same
playbook than the one which install docker.

How:
Check that docker_users are set and not in docker group before include
docker-users.yml. In docker-users.yml we call reset_connection from
ansible.builtin.meta collection after docker-users are added to docker
group.

Manual success tests:
* Try to install docker with only one user in docker-users and not in
  docker group => docker-users.yml include
* Try to install docker with only one user in docker-users but the user
  is in docker group => docker-users.yml not include
* Try to install docker with 2 users in docker-users, one user in docker
  group and the second not => docker-users.yml include
* Try to install docker with 2 users in docker-users, both are in docker
  group => docker-users.yml not include
* Try to install docker with 2 users in docker-users, both are not in
  docker group => docker-users.yml include
2022-08-24 17:07:45 +02:00
Jeff Geerling
53c5490523 PR #320: Use main.yml instead of default.yml for vars defaults. 2022-08-19 14:13:01 -05:00
Jeff Geerling
d3fcc22713
Merge pull request #320 from adamus1red/adamus1red/os-vars
Add OS specific variable overrides.
2022-08-19 14:09:16 -05:00
Jeff Geerling
93eef333bc
Update tasks/main.yml 2022-08-19 14:09:04 -05:00
Jeff Geerling
f78eb9d639
Update tasks/main.yml 2022-08-19 14:09:00 -05:00
Jeff Geerling
11345ab410
Merge pull request #365 from j-koehler/i205-install-docker-packages-explicitly
#205 - install Docker packages explicitly
2022-08-01 10:01:25 -05:00
Jeff Geerling
66cd55df09
Merge pull request #361 from dragetd/patch-1
Avoid string-based module configuration
2022-08-01 09:57:05 -05:00
Jeff Geerling
ccf6905017
Merge pull request #364 from kaysond/master
Add installation of docker plugin from docker's repo
2022-08-01 09:56:30 -05:00
Jeff Geerling
da9b7f78ee
Merge pull request #340 from jwhb/feature-service-manage
Allow skipping of service management
2022-08-01 09:55:50 -05:00
j.koehler
279392701d #205 - remove EoL Debian/Ubuntu versions, add Ubuntu 22.04 (jammy)
- Docker no longer lists Debian 9 and Ubuntu 16.04 LTS under "OS requirements" and there are also no molecule tests for Ubuntu 16.04
- Added Ubuntu 22.04 LTS while on it
2022-07-14 12:35:21 +02:00
j.koehler
99e501c366 #205 - install Docker packages explicitly
following official Docker engine installation instructions
2022-07-14 12:16:39 +02:00
Aram Akhavan
028a764e83 add installation of docker plugin from repo 2022-07-05 19:39:39 -07:00
Michael G
ff37406248
Avoid string-based module configuration
Configure module parameters as a YAML dict instead of string.
2022-06-23 07:02:31 +02:00
Jeff Geerling
f583d39a84
Merge pull request #359 from megabug/fix-gnupg-condition
Correct gnupg installation condition
2022-06-17 10:24:50 -05:00
Matthew Daley
5d35e0208c Correct gnupg installation condition 2022-06-18 00:08:48 +12:00
Jeff Geerling
8453301f62
Merge pull request #356 from fgierlinger/fix/extra-ini-spaces
fix: remove extra spaces on enable option in ini files
2022-06-07 09:49:41 -05:00
fgierlinger
e42ed58e46
chore: change yes to true 2022-06-07 14:34:26 +02:00
fgierlinger
efebb627b9
fix: remove extra spaces on enable option in ini files 2022-06-07 14:30:22 +02:00
Jeff Geerling
32fd595d07 Add role_name_check skipping to all molecule test suites. 2022-06-01 22:20:37 -05:00
Jeff Geerling
2bc23db51a
Merge pull request #352 from crate-workbench/amo/allow-downgrades-debian-redhat-only
Fix package downgrading for non-{RedHat,Debian} systems
2022-05-24 23:23:22 -05:00
Andreas Motl
887eee43c7 Fix package downgrading for non-{RedHat,Debian} systems
Not all package install handlers implement the `allow_downgrade` option.
For example, using Ansible >= 2.12 on Arch Linux would croak like:

    Unsupported parameters for (ansible.legacy.pacman) module: allow_downgrade.
2022-05-24 23:29:09 +02:00
Jeff Geerling
5b8e39b38e
Merge pull request #343 from Normo/342-fix-docker-compose-update
Fix docker-compose update
2022-04-12 14:10:05 -05:00
Norman Ziegner
c5f2b14d9a
Fix docker-compose update
Signed-off-by: Norman Ziegner <norman.ziegner@ufz.de>
2022-04-12 15:53:25 +02:00
jwhb
83e2c066c1 Allow skipping of service management 2022-04-07 11:23:29 +02:00
Jeff Geerling
9b819a6c51
Merge pull request #339 from bajalnyt/master
Update conditional for docker-compose check
2022-04-04 22:08:31 -05:00
Bajal
a9fe63f768
Needs additional check 2022-04-04 21:01:36 -04:00
Bajal
b48741f289
Update conditional for docker-compose check 2022-04-04 20:46:43 -04:00
Jeff Geerling
cef4b7892e Attempt to fix some Docker compose version comparison bugs. 2022-04-04 10:32:17 -05:00
Jeff Geerling
48d5a077d5 Fixes #304: Default to v2.4.1 for Docker Compose. 2022-04-04 09:43:50 -05:00