Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-18 00:19:49 +01:00
Code Issues Projects Releases Wiki Activity

chore: remove deprecated getAdmin from client features store (#9497)

Browse Source 
This method has been deprecated 2 years ago and is not used
This commit is contained in:
Gastón Fournier 2025-03-11 12:04:25 +01:00 committed by GitHub
parent d0597bc054
commit 111a676093
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 2 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/lib/features/client-feature-toggles/client-feature-toggle-store.ts
View File

@ -31,12 +31,6 @@ export interface IGetAllFeatures {
userId?: number;
}
export interface IGetAdminFeatures {
featureQuery?: IFeatureToggleQuery;
archived?: boolean;
userId?: number;
}
export default class FeatureToggleClientStore
implements IFeatureToggleClientStore
{
@ -369,19 +363,6 @@ export default class FeatureToggleClientStore
requestType: 'playground',
});
}
async getAdmin({
featureQuery,
userId,
archived,
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
return this.getAll({
featureQuery,
archived: Boolean(archived),
requestType: 'admin',
userId,
});
}
}
module.exports = FeatureToggleClientStore;

12
src/lib/features/client-feature-toggles/fakes/fake-client-feature-toggle-store.ts
View File

@ -4,7 +4,6 @@ import type {
IFeatureToggleQuery,
} from '../../../types/model';
import type { IFeatureToggleClientStore } from '../types/client-feature-toggle-store-type';
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
export default class FakeClientFeatureToggleStore
implements IFeatureToggleClientStore
@ -16,7 +15,7 @@ export default class FakeClientFeatureToggleStore
archived: boolean = false,
): Promise<IFeatureToggleClient[]> {
const rows = this.featureToggles.filter((toggle) => {
if (featureQuery.namePrefix) {
if (featureQuery?.namePrefix) {
if (featureQuery.project) {
return (
toggle.name.startsWith(featureQuery.namePrefix) &&
@ -27,7 +26,7 @@ export default class FakeClientFeatureToggleStore
}
return toggle.name.startsWith(featureQuery.namePrefix);
}
if (featureQuery.project) {
if (featureQuery?.project) {
return featureQuery.project.some((project) =>
project.includes(toggle.project),
);
@ -73,13 +72,6 @@ export default class FakeClientFeatureToggleStore
}));
}
async getAdmin({
featureQuery: query,
archived,
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
return this.getFeatures(query, archived);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async createFeature(feature: any): Promise<void> {
this.featureToggles.push({

4
src/lib/features/client-feature-toggles/types/client-feature-toggle-store-type.ts
View File

@ -2,7 +2,6 @@ import type {
IFeatureToggleClient,
IFeatureToggleQuery,
} from '../../../types/model';
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
export interface IFeatureToggleClientStore {
getClient(
@ -16,7 +15,4 @@ export interface IFeatureToggleClientStore {
getPlayground(
featureQuery: Partial<IFeatureToggleQuery>,
): Promise<IFeatureToggleClient[]>;
// @Deprecated
getAdmin(params: IGetAdminFeatures): Promise<IFeatureToggleClient[]>;
}