1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-23 00:16:25 +01:00

chore: remove deprecated getAdmin from client features store ()

This method has been deprecated 2 years ago and is not used
This commit is contained in:
Gastón Fournier 2025-03-11 12:04:25 +01:00 committed by GitHub
parent d0597bc054
commit 111a676093
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 2 additions and 33 deletions

View File

@ -31,12 +31,6 @@ export interface IGetAllFeatures {
userId?: number; userId?: number;
} }
export interface IGetAdminFeatures {
featureQuery?: IFeatureToggleQuery;
archived?: boolean;
userId?: number;
}
export default class FeatureToggleClientStore export default class FeatureToggleClientStore
implements IFeatureToggleClientStore implements IFeatureToggleClientStore
{ {
@ -369,19 +363,6 @@ export default class FeatureToggleClientStore
requestType: 'playground', requestType: 'playground',
}); });
} }
async getAdmin({
featureQuery,
userId,
archived,
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
return this.getAll({
featureQuery,
archived: Boolean(archived),
requestType: 'admin',
userId,
});
}
} }
module.exports = FeatureToggleClientStore; module.exports = FeatureToggleClientStore;

View File

@ -4,7 +4,6 @@ import type {
IFeatureToggleQuery, IFeatureToggleQuery,
} from '../../../types/model'; } from '../../../types/model';
import type { IFeatureToggleClientStore } from '../types/client-feature-toggle-store-type'; import type { IFeatureToggleClientStore } from '../types/client-feature-toggle-store-type';
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
export default class FakeClientFeatureToggleStore export default class FakeClientFeatureToggleStore
implements IFeatureToggleClientStore implements IFeatureToggleClientStore
@ -16,7 +15,7 @@ export default class FakeClientFeatureToggleStore
archived: boolean = false, archived: boolean = false,
): Promise<IFeatureToggleClient[]> { ): Promise<IFeatureToggleClient[]> {
const rows = this.featureToggles.filter((toggle) => { const rows = this.featureToggles.filter((toggle) => {
if (featureQuery.namePrefix) { if (featureQuery?.namePrefix) {
if (featureQuery.project) { if (featureQuery.project) {
return ( return (
toggle.name.startsWith(featureQuery.namePrefix) && toggle.name.startsWith(featureQuery.namePrefix) &&
@ -27,7 +26,7 @@ export default class FakeClientFeatureToggleStore
} }
return toggle.name.startsWith(featureQuery.namePrefix); return toggle.name.startsWith(featureQuery.namePrefix);
} }
if (featureQuery.project) { if (featureQuery?.project) {
return featureQuery.project.some((project) => return featureQuery.project.some((project) =>
project.includes(toggle.project), project.includes(toggle.project),
); );
@ -73,13 +72,6 @@ export default class FakeClientFeatureToggleStore
})); }));
} }
async getAdmin({
featureQuery: query,
archived,
}: IGetAdminFeatures): Promise<IFeatureToggleClient[]> {
return this.getFeatures(query, archived);
}
// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
async createFeature(feature: any): Promise<void> { async createFeature(feature: any): Promise<void> {
this.featureToggles.push({ this.featureToggles.push({

View File

@ -2,7 +2,6 @@ import type {
IFeatureToggleClient, IFeatureToggleClient,
IFeatureToggleQuery, IFeatureToggleQuery,
} from '../../../types/model'; } from '../../../types/model';
import type { IGetAdminFeatures } from '../client-feature-toggle-store';
export interface IFeatureToggleClientStore { export interface IFeatureToggleClientStore {
getClient( getClient(
@ -16,7 +15,4 @@ export interface IFeatureToggleClientStore {
getPlayground( getPlayground(
featureQuery: Partial<IFeatureToggleQuery>, featureQuery: Partial<IFeatureToggleQuery>,
): Promise<IFeatureToggleClient[]>; ): Promise<IFeatureToggleClient[]>;
// @Deprecated
getAdmin(params: IGetAdminFeatures): Promise<IFeatureToggleClient[]>;
} }