Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: avoid direct mutation of setState return value (#1034)

Browse Source
This commit is contained in:
olav 2022-05-27 10:04:26 +02:00 committed by GitHub
parent 25c25c9206
commit 19f97a388e
1 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
frontend/src/component/addons/AddonForm/AddonForm.tsx
View File

@ -108,14 +108,19 @@ export const AddonForm: VFC<IAddonFormProps> = ({
const setEventValue = const setEventValue =
(name: string) => (event: ChangeEvent<HTMLInputElement>) => { (name: string) => (event: ChangeEvent<HTMLInputElement>) => {
const newConfig = { ...formValues }; setFormValues(
if (event.target.checked) { produce(draft => {
newConfig.events.push(name); if (event.target.checked) {
} else { draft.events.push(name);
newConfig.events = newConfig.events.filter(e => e !== name); } else {
} draft.events = draft.events.filter(e => e !== name);
setFormValues(newConfig); }
setErrors({ ...errors, events: undefined }); })
);
setErrors(prev => ({
...prev,
events: undefined,
}));
}; };
const onCancel = () => { const onCancel = () => {