Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

chore: make sdk metrics snake case (#7547)

Browse Source
This commit is contained in:
Simon Hornby 2024-07-05 12:29:00 +02:00 committed by GitHub
parent 165f02a3a4
commit 2e205fc14e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/lib/metrics.test.ts
View File

@ -266,10 +266,10 @@ test('Should collect metrics for client sdk versions', async () => {
'client_sdk_versions',
);
expect(metrics).toMatch(
/client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 3/,
/client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 3/,
);
expect(metrics).toMatch(
/client_sdk_versions\{sdk_name="unleash-client-java",sdk_version="5\.0\.0"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 3/,
/client_sdk_versions\{sdk_name="unleash-client-java",sdk_version="5\.0\.0"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 3/,
);
eventStore.emit(CLIENT_REGISTER, {
sdkName: 'unleash-client-node',
@ -279,7 +279,7 @@ test('Should collect metrics for client sdk versions', async () => {
'client_sdk_versions',
);
expect(newmetrics).toMatch(
/client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platformName=\"not-set\",platformVersion=\"not-set\",yggdrasilVersion=\"not-set\",specVersion=\"not-set\"} 4/,
/client_sdk_versions\{sdk_name="unleash-client-node",sdk_version="3\.2\.5"\,platform_name=\"not-set\",platform_version=\"not-set\",yggdrasil_version=\"not-set\",spec_version=\"not-set\"} 4/,
);
});

24
src/lib/metrics.ts
View File

@ -248,10 +248,10 @@ export default class MetricsMonitor {
labelNames: [
'sdk_name',
'sdk_version',
'platformName',
'platformVersion',
'yggdrasilVersion',
'specVersion',
'platform_name',
'platform_version',
'yggdrasil_version',
'spec_version',
],
});
@ -801,23 +801,23 @@ export default class MetricsMonitor {
clientSdkVersionUsage.increment({
sdk_name: heartbeatEvent.sdkName,
sdk_version: heartbeatEvent.sdkVersion,
platformName:
platform_name:
heartbeatEvent.metadata?.platformName ?? 'not-set',
platformVersion:
platform_version:
heartbeatEvent.metadata?.platformVersion ?? 'not-set',
yggdrasilVersion:
yggdrasil_version:
heartbeatEvent.metadata?.yggdrasilVersion ?? 'not-set',
specVersion:
spec_version:
heartbeatEvent.metadata?.specVersion ?? 'not-set',
});
} else {
clientSdkVersionUsage.increment({
sdk_name: heartbeatEvent.sdkName,
sdk_version: heartbeatEvent.sdkVersion,
platformName: 'not-set',
platformVersion: 'not-set',
yggdrasilVersion: 'not-set',
specVersion: 'not-set',
platform_name: 'not-set',
platform_version: 'not-set',
yggdrasil_version: 'not-set',
spec_version: 'not-set',
});
}
});