Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-27 01:19:00 +02:00
Code Issues Projects Releases Wiki Activity

Chore/remove flag disable bulk toggle (#10183)

Browse Source 
Prompt used:

![image](https://github.com/user-attachments/assets/17d35ab4-cc2c-4f90-9bee-7fdc3550e1ec)

LLM: Gemini 2.5 Pro (preview)

@kwasniew do we still need this kill-switch?
This commit is contained in:
Ivar Conradi Østhus 2025-06-20 13:18:50 +02:00 committed by GitHub
parent f9ca769179
commit 2ecb4b0a4f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 14 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeaturesBatchActions/ProjectFeaturesBatchActions.tsx
View File

@ -9,7 +9,6 @@ import { usePlausibleTracker } from 'hooks/usePlausibleTracker';
import { BulkDisableDialog } from 'component/feature/FeatureToggleList/BulkDisableDialog'; import { BulkDisableDialog } from 'component/feature/FeatureToggleList/BulkDisableDialog';
import { BulkEnableDialog } from 'component/feature/FeatureToggleList/BulkEnableDialog'; import { BulkEnableDialog } from 'component/feature/FeatureToggleList/BulkEnableDialog';
import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig'; import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
interface IProjectFeaturesBatchActionsProps { interface IProjectFeaturesBatchActionsProps {
selectedIds: string[]; selectedIds: string[];
@ -72,32 +71,20 @@ export const ProjectFeaturesBatchActions: FC<
return ( return (
<> <>
<ConditionallyRender <Button
condition={Boolean(uiConfig?.flags?.disableBulkToggle)} variant='outlined'
show={null} size='small'
elseShow={ onClick={() => setShowBulkEnableDialog(true)}
<Button >
variant='outlined' Enable
size='small' </Button>
onClick={() => setShowBulkEnableDialog(true)} <Button
> variant='outlined'
Enable size='small'
</Button> onClick={() => setShowBulkDisableDialog(true)}
} >
/> Disable
<ConditionallyRender </Button>
condition={Boolean(uiConfig?.flags?.disableBulkToggle)}
show={null}
elseShow={
<Button
variant='outlined'
size='small'
onClick={() => setShowBulkDisableDialog(true)}
>
Disable
</Button>
}
/>
<ArchiveButton <ArchiveButton
projectId={projectId} projectId={projectId}
featureIds={selectedIds} featureIds={selectedIds}

1
frontend/src/interfaces/uiConfig.ts
View File

@ -59,7 +59,6 @@ export type UiFlags = {
personalAccessTokensKillSwitch?: boolean; personalAccessTokensKillSwitch?: boolean;
demo?: boolean; demo?: boolean;
googleAuthEnabled?: boolean; googleAuthEnabled?: boolean;
disableBulkToggle?: boolean;
advancedPlayground?: boolean; advancedPlayground?: boolean;
strategyVariant?: boolean; strategyVariant?: boolean;
doraMetrics?: boolean; doraMetrics?: boolean;

10
src/lib/features/feature-toggle/feature-toggle-controller.ts
View File

@ -918,11 +918,6 @@ export default class ProjectFeaturesController extends Controller {
const { shouldActivateDisabledStrategies } = req.query; const { shouldActivateDisabledStrategies } = req.query;
const { features } = req.body; const { features } = req.body;
if (this.flagResolver.isEnabled('disableBulkToggle')) {
res.status(403).end();
return;
}
await this.transactionalFeatureToggleService.transactional((service) => await this.transactionalFeatureToggleService.transactional((service) =>
service.bulkUpdateEnabled( service.bulkUpdateEnabled(
projectId, projectId,
@ -950,11 +945,6 @@ export default class ProjectFeaturesController extends Controller {
const { shouldActivateDisabledStrategies } = req.query; const { shouldActivateDisabledStrategies } = req.query;
const { features } = req.body; const { features } = req.body;
if (this.flagResolver.isEnabled('disableBulkToggle')) {
res.status(403).end();
return;
}
await this.transactionalFeatureToggleService.transactional((service) => await this.transactionalFeatureToggleService.transactional((service) =>
service.bulkUpdateEnabled( service.bulkUpdateEnabled(
projectId, projectId,

5
src/lib/types/experimental.ts
View File

@ -17,7 +17,6 @@ export type IFlagKey =
| 'migrationLock' | 'migrationLock'
| 'demo' | 'demo'
| 'googleAuthEnabled' | 'googleAuthEnabled'
| 'disableBulkToggle'
| 'advancedPlayground' | 'advancedPlayground'
| 'filterInvalidClientMetrics' | 'filterInvalidClientMetrics'
| 'disableMetrics' | 'disableMetrics'
@ -105,10 +104,6 @@ const flags: IFlags = {
process.env.GOOGLE_AUTH_ENABLED, process.env.GOOGLE_AUTH_ENABLED,
false, false,
), ),
disableBulkToggle: parseEnvVarBoolean(
process.env.DISABLE_BULK_TOGGLE,
false,
),
filterInvalidClientMetrics: parseEnvVarBoolean( filterInvalidClientMetrics: parseEnvVarBoolean(
process.env.FILTER_INVALID_CLIENT_METRICS, process.env.FILTER_INVALID_CLIENT_METRICS,
false, false,