chore: clarify deleted legal values warning (#9969)

frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.test.tsx

@@ -28,7 +28,7 @@ test('should show alert when you have illegal legal values', async () => {
     );
 
     await screen.findByText(
-        'This constraint is using legal values that have been deleted as valid options. If you save changes on this constraint and then save the strategy the following values will be removed:',
+        'This constraint is currently using values that were valid in the past but have since been deleted. If you save changes on this constraint and then save the strategy the following values will be removed:',
     );
 });
 

frontend/src/component/common/NewConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/RestrictiveLegalValues/RestrictiveLegalValues.tsx

@@ -173,10 +173,10 @@ export const RestrictiveLegalValues = ({
                 condition={Boolean(illegalValues && illegalValues.length > 0)}
                 show={
                     <Alert severity='warning'>
-                        This constraint is using legal values that have been
+                        This constraint is currently using values that were
-                        deleted as valid options. If you save changes on this
+                        valid in the past but have since been deleted. If you
-                        constraint and then save the strategy the following
+                        save changes on this constraint and then save the
-                        values will be removed:
+                        strategy the following values will be removed:
                         <ul>
                             {illegalValues?.map((value) => (
                                 <li key={value}>{value}</li>

frontend/src/component/common/Table/cells/FeatureOverviewCell/FeatureOverviewCell.tsx

@@ -17,7 +17,6 @@ import { useFeature } from 'hooks/api/getters/useFeature/useFeature';
 import { useLocationSettings } from 'hooks/useLocationSettings';
 import { getLocalizedDateString } from '../../../util';
 import { Tag } from 'component/common/Tag/Tag';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { formatTag } from 'utils/format-tag';
 
 interface IFeatureNameCellProps {

frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/LegalValuesSelector.tsx

@@ -77,9 +77,10 @@ const BaseLegalValueSelector: FC<BaseProps> = ({
         <LegalValuesSelectorWidget>
             {deletedLegalValues?.size ? (
                 <Alert id={alertId} severity='warning'>
-                    This constraint is using legal values that have been deleted
+                    This constraint is currently using values that were valid in
-                    as valid options. If you save changes on this constraint and
+                    the past but have since been deleted. If you save changes on
-                    then save the strategy the following values will be removed:
+                    this constraint and then save the strategy the following
+                    values will be removed:
                     <ul>
                         {[...deletedLegalValues].map((value) => (
                             <li key={value}>{value}</li>

frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewMetaData/TagRow.tsx

@@ -2,7 +2,6 @@ import type { IFeatureToggle } from 'interfaces/featureToggle';
 import { useContext, useState } from 'react';
 import { styled, Tooltip, Chip } from '@mui/material';
 import useFeatureTags from 'hooks/api/getters/useFeatureTags/useFeatureTags';
-import DeleteTagIcon from '@mui/icons-material/Cancel';
 import ClearIcon from '@mui/icons-material/Clear';
 import { ManageTagsDialog } from 'component/feature/FeatureView/FeatureOverview/ManageTagsDialog/ManageTagsDialog';
 import { UPDATE_FEATURE } from 'component/providers/AccessProvider/permissions';
@@ -15,7 +14,6 @@ import { formatUnknownError } from 'utils/formatUnknownError';
 import { StyledMetaDataItem } from './FeatureOverviewMetaData';
 import { AddTagButton } from './AddTagButton';
 import { Tag } from 'component/common/Tag/Tag';
-import { useUiFlag } from 'hooks/useUiFlag';
 import { formatTag } from 'utils/format-tag';
 
 const StyledLabel = styled('span')(({ theme }) => ({

frontend/src/component/tags/TagTypeForm/useTagTypeForm.ts

@@ -1,7 +1,6 @@
 import { useEffect, useState } from 'react';
 import useTagTypesApi from 'hooks/api/actions/useTagTypesApi/useTagTypesApi';
 import { formatUnknownError } from 'utils/formatUnknownError';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 interface TagTypePayload {
     name: string;

frontend/src/component/tags/TagTypeList/TagTypeList.tsx

@@ -31,7 +31,6 @@ import { LinkCell } from 'component/common/Table/cells/LinkCell/LinkCell';
 import { sortTypes } from 'utils/sortTypes';
 import { AddTagTypeButton } from './AddTagTypeButton/AddTagTypeButton';
 import { Search } from 'component/common/Search/Search';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 const StyledColorDot = styled('div')<{ $color: string }>(
     ({ theme, $color }) => ({