Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-13 13:48:59 +02:00
Code Issues Projects Releases Wiki Activity

fix(1-3363): frontend flag type should not return truthy for variant

Browse Source
This commit is contained in:
Tymoteusz Czech 2025-02-11 13:48:17 +01:00
parent ea06565ca7
commit 3cb7791452
No known key found for this signature in database
GPG Key ID: 133555230D88D75F
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/hooks/useUiFlag.ts
View File

@ -2,8 +2,11 @@ import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
type flags = ReturnType<typeof useUiConfig>['uiConfig']['flags'];
export const useUiFlag = <K extends keyof flags>(flag: K) => {
export const useUiFlag = <K extends keyof flags>(flag: K): boolean => {
const { uiConfig } = useUiConfig();
if (typeof uiConfig?.flags?.[flag] !== 'boolean') {
console.error(`Flag ${flag} is undefined or a variant.`);
}
return uiConfig?.flags?.[flag] || false;
return Boolean(uiConfig?.flags?.[flag]) || false;
};

15
src/lib/types/experimental.ts
View File

@ -310,10 +310,17 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_DATA_USAGE_MULTI_MONTH_VIEW,
false,
),
uiGlobalFontSize: parseEnvVarBoolean(
process.env.EXPERIMENTAL_UI_GLOBAL_FONT_SIZE_NAME,
false,
),
uiGlobalFontSize: {
name: 'uiGlobalFontSize',
enabled: parseEnvVarBoolean(
process.env.EXPERIMENTAL_UI_GLOBAL_FONT_SIZE_NAME,
false,
),
payload: {
type: PayloadType.JSON,
value: '14',
},
},
};
export const defaultExperimentalOptions: IExperimentalOptions = {