Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-23 00:22:19 +01:00
Code Issues Projects Releases Wiki Activity

fix: last seen is now using last seen values from new table (#5380)

Browse Source 
In short the issue is that after our last seen improvements, we did not
update where we are getting last_seen field. It was still using features
table, which is not the source of last seen anymore.
This commit is contained in:
Jaanus Sellin 2023-11-21 14:44:41 +02:00 committed by GitHub
parent fe4bb4f227
commit 62dbf8d12f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
View File

@ -386,7 +386,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
acc.description = r.description;
acc.project = r.project;
acc.stale = r.stale;
acc.lastSeenAt = r.last_seen_at;
acc.createdAt = r.created_at;
acc.type = r.type;
@ -396,6 +395,14 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
lastSeenAt: r.env_last_seen_at,
};
}
if (
acc.lastSeenAt === undefined ||
new Date(r.env_last_seen_at) > new Date(acc.lastSeenAt)
) {
acc.lastSeenAt = r.env_last_seen_at;
}
const env = acc.environments[r.environment];
const variants = r.variants || [];
@ -650,7 +657,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
'features.description as description',
'features.type as type',
'features.created_at as created_at',
'features.last_seen_at as last_seen_at',
'features.stale as stale',
'features.impression_data as impression_data',
'feature_environments.enabled as enabled',
@ -808,7 +814,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
'features.description as description',
'features.type as type',
'features.created_at as created_at',
'features.last_seen_at as last_seen_at',
'features.stale as stale',
'features.impression_data as impression_data',
'feature_environments.enabled as enabled',
@ -890,7 +895,6 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
favorite: row.favorite,
name: row.feature_name,
createdAt: row.created_at,
lastSeenAt: row.last_seen_at,
stale: row.stale,
impressionData: row.impression_data,
environments: [FeatureStrategiesStore.getEnvironment(row)],
@ -900,6 +904,13 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
this.addTag(acc[row.feature_name], row);
}
}
const featureRow = acc[row.feature_name];
if (
featureRow.lastSeenAt === undefined ||
new Date(row.env_last_seen_at) > new Date(featureRow.lastSeenAt)
) {
featureRow.lastSeenAt = row.env_last_seen_at;
}
return acc;
}, {});
}