Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-21 13:47:39 +02:00
Code Issues Projects Releases Wiki Activity

chore: remove teams integration CR events flag (#10015)

Browse Source 
https://linear.app/unleash/issue/2-3265/investigate-teams-integration-for-change-request-notifications

Removes the `teamsIntegrationChangeRequests` feature flag.

Follow-up to: https://github.com/Unleash/unleash/pull/9309
This commit is contained in:
Nuno Góis 2025-05-16 15:06:53 +01:00 committed by GitHub
parent 1a0cfd6821
commit 8fae8fb8b3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 30 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/lib/addons/teams-definition.ts
View File

@ -14,6 +14,21 @@ import {
FEATURE_PROJECT_CHANGE, FEATURE_PROJECT_CHANGE,
FEATURE_VARIANTS_UPDATED, FEATURE_VARIANTS_UPDATED,
FEATURE_POTENTIALLY_STALE_ON, FEATURE_POTENTIALLY_STALE_ON,
CHANGE_ADDED,
CHANGE_DISCARDED,
CHANGE_EDITED,
CHANGE_REQUEST_APPLIED,
CHANGE_REQUEST_APPROVAL_ADDED,
CHANGE_REQUEST_APPROVED,
CHANGE_REQUEST_CANCELLED,
CHANGE_REQUEST_CREATED,
CHANGE_REQUEST_DISCARDED,
CHANGE_REQUEST_REJECTED,
CHANGE_REQUEST_SENT_TO_REVIEW,
CHANGE_REQUEST_SCHEDULED,
CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
CHANGE_REQUEST_SCHEDULE_SUSPENDED,
} from '../events/index.js'; } from '../events/index.js';
import type { IAddonDefinition } from '../types/model.js'; import type { IAddonDefinition } from '../types/model.js';
@ -61,6 +76,21 @@ const teamsDefinition: IAddonDefinition = {
FEATURE_VARIANTS_UPDATED, FEATURE_VARIANTS_UPDATED,
FEATURE_PROJECT_CHANGE, FEATURE_PROJECT_CHANGE,
FEATURE_POTENTIALLY_STALE_ON, FEATURE_POTENTIALLY_STALE_ON,
CHANGE_ADDED,
CHANGE_DISCARDED,
CHANGE_EDITED,
CHANGE_REQUEST_APPLIED,
CHANGE_REQUEST_APPROVAL_ADDED,
CHANGE_REQUEST_APPROVED,
CHANGE_REQUEST_CANCELLED,
CHANGE_REQUEST_CREATED,
CHANGE_REQUEST_DISCARDED,
CHANGE_REQUEST_REJECTED,
CHANGE_REQUEST_SENT_TO_REVIEW,
CHANGE_REQUEST_SCHEDULED,
CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
CHANGE_REQUEST_SCHEDULE_SUSPENDED,
], ],
}; };

38
src/lib/addons/teams.ts
View File

@ -13,24 +13,6 @@ import {
import type { IEvent } from '../events/index.js'; import type { IEvent } from '../events/index.js';
import type { IntegrationEventState } from '../features/integration-events/integration-events-store.js'; import type { IntegrationEventState } from '../features/integration-events/integration-events-store.js';
import {
CHANGE_ADDED,
CHANGE_DISCARDED,
CHANGE_EDITED,
CHANGE_REQUEST_APPLIED,
CHANGE_REQUEST_APPROVAL_ADDED,
CHANGE_REQUEST_APPROVED,
CHANGE_REQUEST_CANCELLED,
CHANGE_REQUEST_CREATED,
CHANGE_REQUEST_DISCARDED,
CHANGE_REQUEST_REJECTED,
CHANGE_REQUEST_SENT_TO_REVIEW,
CHANGE_REQUEST_SCHEDULED,
CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
CHANGE_REQUEST_SCHEDULE_SUSPENDED,
} from '../events/index.js';
interface ITeamsParameters { interface ITeamsParameters {
url: string; url: string;
customHeaders?: string; customHeaders?: string;
@ -41,26 +23,6 @@ export default class TeamsAddon extends Addon {
declare flagResolver: IFlagResolver; declare flagResolver: IFlagResolver;
constructor(args: IAddonConfig) { constructor(args: IAddonConfig) {
if (args.flagResolver.isEnabled('teamsIntegrationChangeRequests')) {
teamsDefinition.events = [
...teamsDefinition.events!,
CHANGE_ADDED,
CHANGE_DISCARDED,
CHANGE_EDITED,
CHANGE_REQUEST_APPLIED,
CHANGE_REQUEST_APPROVAL_ADDED,
CHANGE_REQUEST_APPROVED,
CHANGE_REQUEST_CANCELLED,
CHANGE_REQUEST_CREATED,
CHANGE_REQUEST_DISCARDED,
CHANGE_REQUEST_REJECTED,
CHANGE_REQUEST_SENT_TO_REVIEW,
CHANGE_REQUEST_SCHEDULED,
CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS,
CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
CHANGE_REQUEST_SCHEDULE_SUSPENDED,
];
}
super(teamsDefinition, args); super(teamsDefinition, args);
this.msgFormatter = new FeatureEventFormatterMd({ this.msgFormatter = new FeatureEventFormatterMd({
unleashUrl: args.unleashUrl, unleashUrl: args.unleashUrl,

5
src/lib/types/experimental.ts
View File

@ -55,7 +55,6 @@ export type IFlagKey =
| 'deltaApi' | 'deltaApi'
| 'uniqueSdkTracking' | 'uniqueSdkTracking'
| 'consumptionModel' | 'consumptionModel'
| 'teamsIntegrationChangeRequests'
| 'edgeObservability' | 'edgeObservability'
| 'addEditStrategy' | 'addEditStrategy'
| 'cleanupReminder' | 'cleanupReminder'
@ -266,10 +265,6 @@ const flags: IFlags = {
process.env.EXPERIMENTAL_CONSUMPTION_MODEL, process.env.EXPERIMENTAL_CONSUMPTION_MODEL,
false, false,
), ),
teamsIntegrationChangeRequests: parseEnvVarBoolean(
process.env.EXPERIMENTAL_TEAMS_INTEGRATION_CHANGE_REQUESTS,
false,
),
edgeObservability: parseEnvVarBoolean( edgeObservability: parseEnvVarBoolean(
process.env.EXPERIMENTAL_EDGE_OBSERVABILITY, process.env.EXPERIMENTAL_EDGE_OBSERVABILITY,
false, false,

1
src/server-dev.ts
View File

@ -50,7 +50,6 @@ process.nextTick(async () => {
showUserDeviceCount: true, showUserDeviceCount: true,
deltaApi: true, deltaApi: true,
uniqueSdkTracking: true, uniqueSdkTracking: true,
teamsIntegrationChangeRequests: true,
addEditStrategy: true, addEditStrategy: true,
cleanupReminder: true, cleanupReminder: true,
strictSchemaValidation: true, strictSchemaValidation: true,