1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00

feat: histogram impact metric UI

This commit is contained in:
kwasniew 2025-09-24 10:42:38 +02:00
parent 0d942411ac
commit b93968a17b
No known key found for this signature in database
GPG Key ID: 43A7CBC24C119560
2 changed files with 7 additions and 7 deletions

View File

@ -58,7 +58,7 @@ export const ImpactMetricsControls: FC<ImpactMetricsControlsProps> = ({
<ModeSelector
value={formData.aggregationMode}
onChange={actions.setAggregationMode}
seriesType={getMetricType(formData.metricName)!}
metricType={getMetricType(formData.metricName)!}
/>
</>
) : null}

View File

@ -5,15 +5,15 @@ import type { AggregationMode } from '../../../types.ts';
export type ModeSelectorProps = {
value: AggregationMode;
onChange: (mode: AggregationMode) => void;
seriesType: 'counter' | 'gauge' | 'histogram' | 'unknown';
metricType: 'counter' | 'gauge' | 'histogram' | 'unknown';
};
export const ModeSelector: FC<ModeSelectorProps> = ({
value,
onChange,
seriesType,
metricType,
}) => {
if (seriesType === 'unknown') return null;
if (metricType === 'unknown') return null;
return (
<FormControl variant='outlined' size='small' sx={{ minWidth: 200 }}>
<InputLabel id='mode-select-label'>Mode</InputLabel>
@ -23,7 +23,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
onChange={(e) => onChange(e.target.value as AggregationMode)}
label='Mode'
>
{seriesType === 'counter'
{metricType === 'counter'
? [
<MenuItem key='rps' value='rps'>
Rate per second
@ -32,7 +32,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
Count
</MenuItem>,
]
: seriesType === 'gauge'
: metricType === 'gauge'
? [
<MenuItem key='avg' value='avg'>
Average
@ -41,7 +41,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
Sum
</MenuItem>,
]
: seriesType === 'histogram'
: metricType === 'histogram'
? [
<MenuItem key='p50' value='p50'>
50th percentile