Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00
Code Issues Projects Releases Wiki Activity

feat: histogram impact metric UI

Browse Source
This commit is contained in:
kwasniew 2025-09-24 10:42:38 +02:00
parent 0d942411ac
commit b93968a17b
No known key found for this signature in database
GPG Key ID: 43A7CBC24C119560
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ImpactMetricsControls.tsx
View File

@ -58,7 +58,7 @@ export const ImpactMetricsControls: FC<ImpactMetricsControlsProps> = ({
<ModeSelector <ModeSelector
value={formData.aggregationMode} value={formData.aggregationMode}
onChange={actions.setAggregationMode} onChange={actions.setAggregationMode}
seriesType={getMetricType(formData.metricName)!} metricType={getMetricType(formData.metricName)!}
/> />
</> </>
) : null} ) : null}

12
frontend/src/component/impact-metrics/ChartConfigModal/ImpactMetricsControls/ModeSelector/ModeSelector.tsx
View File

@ -5,15 +5,15 @@ import type { AggregationMode } from '../../../types.ts';
export type ModeSelectorProps = { export type ModeSelectorProps = {
value: AggregationMode; value: AggregationMode;
onChange: (mode: AggregationMode) => void; onChange: (mode: AggregationMode) => void;
seriesType: 'counter' | 'gauge' | 'histogram' | 'unknown'; metricType: 'counter' | 'gauge' | 'histogram' | 'unknown';
}; };
export const ModeSelector: FC<ModeSelectorProps> = ({ export const ModeSelector: FC<ModeSelectorProps> = ({
value, value,
onChange, onChange,
seriesType, metricType,
}) => { }) => {
if (seriesType === 'unknown') return null; if (metricType === 'unknown') return null;
return ( return (
<FormControl variant='outlined' size='small' sx={{ minWidth: 200 }}> <FormControl variant='outlined' size='small' sx={{ minWidth: 200 }}>
<InputLabel id='mode-select-label'>Mode</InputLabel> <InputLabel id='mode-select-label'>Mode</InputLabel>
@ -23,7 +23,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
onChange={(e) => onChange(e.target.value as AggregationMode)} onChange={(e) => onChange(e.target.value as AggregationMode)}
label='Mode' label='Mode'
> >
{seriesType === 'counter' {metricType === 'counter'
? [ ? [
<MenuItem key='rps' value='rps'> <MenuItem key='rps' value='rps'>
Rate per second Rate per second
@ -32,7 +32,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
Count Count
</MenuItem>, </MenuItem>,
] ]
: seriesType === 'gauge' : metricType === 'gauge'
? [ ? [
<MenuItem key='avg' value='avg'> <MenuItem key='avg' value='avg'>
Average Average
@ -41,7 +41,7 @@ export const ModeSelector: FC<ModeSelectorProps> = ({
Sum Sum
</MenuItem>, </MenuItem>,
] ]
: seriesType === 'histogram' : metricType === 'histogram'
? [ ? [
<MenuItem key='p50' value='p50'> <MenuItem key='p50' value='p50'>
50th percentile 50th percentile