Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-03 01:18:43 +02:00
Code Issues Projects Releases Wiki Activity

chore: Improve UI Config type (#4959)

Browse Source 
Fix link types
This commit is contained in:
Gastón Fournier 2023-10-06 16:31:39 +02:00 committed by GitHub
parent 8b0cf8b11d
commit c3e8d743bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/db/transaction.ts
View File

@ -27,7 +27,7 @@ export type WithTransactional<S> = S & {
}; };
/** /**
* @deprecated this is a temporal solution to deal with transactions at the store level. * @deprecated this is a temporary solution to deal with transactions at the store level.
* Ideally, we should handle transactions at the service level (each service method should be transactional). * Ideally, we should handle transactions at the service level (each service method should be transactional).
* The controller should define the transactional scope as follows: * The controller should define the transactional scope as follows:
* https://github.com/Unleash/unleash/blob/cb034976b93abc799df774858d716a49f645d669/src/lib/features/export-import-toggles/export-import-controller.ts#L206-L208 * https://github.com/Unleash/unleash/blob/cb034976b93abc799df774858d716a49f645d669/src/lib/features/export-import-toggles/export-import-controller.ts#L206-L208

14
src/lib/types/option.ts
View File

@ -148,14 +148,12 @@ export interface IUIConfig {
environment?: string; environment?: string;
slogan?: string; slogan?: string;
name?: string; name?: string;
links?: [ links?: {
{ value: string;
value: string; icon?: string;
icon?: string; href: string;
href: string; title: string;
title: string; }[];
},
];
flags?: IFlags; flags?: IFlags;
} }