Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-17 01:17:29 +02:00
Code Issues Projects Releases Wiki Activity

feat: remove access overview flag making it GA ready (#9654)

Browse Source 
This is exposing information we already have about permissions in a UI
that should help users have an overview of the permissions of a user
with regards to projects and environments
This commit is contained in:
Gastón Fournier 2025-03-31 14:33:38 +02:00 committed by GitHub
parent ce230ba96b
commit eae7535bfc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend/src/component/admin/users/UsersList/UsersList.tsx
View File

@ -58,7 +58,6 @@ const UsersList = () => {
}>({ }>({
open: false, open: false,
}); });
const userAccessUIEnabled = useUiFlag('userAccessUIEnabled');
const showUserDeviceCount = useUiFlag('showUserDeviceCount'); const showUserDeviceCount = useUiFlag('showUserDeviceCount');
const showSSOUpgrade = isOss() && users.length > 3; const showSSOUpgrade = isOss() && users.length > 3;
@ -218,15 +217,9 @@ const UsersList = () => {
onEdit={() => { onEdit={() => {
navigate(`/admin/users/${user.id}/edit`); navigate(`/admin/users/${user.id}/edit`);
}} }}
onViewAccess={ onViewAccess={() => {
userAccessUIEnabled navigate(`/admin/users/${user.id}/access`);
? () => { }}
navigate(
`/admin/users/${user.id}/access`,
);
}
: undefined
}
onChangePassword={openPwDialog(user)} onChangePassword={openPwDialog(user)}
onResetPassword={openResetPwDialog(user)} onResetPassword={openResetPwDialog(user)}
onDelete={openDelDialog(user)} onDelete={openDelDialog(user)}
@ -250,7 +243,7 @@ const UsersList = () => {
searchable: true, searchable: true,
}, },
], ],
[roles, navigate, isBillingUsers, userAccessUIEnabled], [roles, navigate, isBillingUsers],
); );
const initialState = useMemo(() => { const initialState = useMemo(() => {

1
frontend/src/interfaces/uiConfig.ts
View File

@ -74,7 +74,6 @@ export type UiFlags = {
feedbackComments?: Variant; feedbackComments?: Variant;
showInactiveUsers?: boolean; showInactiveUsers?: boolean;
feedbackPosting?: boolean; feedbackPosting?: boolean;
userAccessUIEnabled?: boolean;
outdatedSdksBanner?: boolean; outdatedSdksBanner?: boolean;
estimateTrafficDataCost?: boolean; estimateTrafficDataCost?: boolean;
disableShowContextFieldSelectionValues?: boolean; disableShowContextFieldSelectionValues?: boolean;

5
src/lib/types/experimental.ts
View File

@ -36,7 +36,6 @@ export type IFlagKey =
| 'estimateTrafficDataCost' | 'estimateTrafficDataCost'
| 'useMemoizedActiveTokens' | 'useMemoizedActiveTokens'
| 'queryMissingTokens' | 'queryMissingTokens'
| 'userAccessUIEnabled'
| 'disableUpdateMaxRevisionId' | 'disableUpdateMaxRevisionId'
| 'disablePublishUnannouncedEvents' | 'disablePublishUnannouncedEvents'
| 'outdatedSdksBanner' | 'outdatedSdksBanner'
@ -197,10 +196,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_ESTIMATE_TRAFFIC_DATA_COST, process.env.UNLEASH_EXPERIMENTAL_ESTIMATE_TRAFFIC_DATA_COST,
false, false,
), ),
userAccessUIEnabled: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_USER_ACCESS_UI_ENABLED,
false,
),
disableUpdateMaxRevisionId: parseEnvVarBoolean( disableUpdateMaxRevisionId: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_DISABLE_SCHEDULED_CACHES, process.env.UNLEASH_EXPERIMENTAL_DISABLE_SCHEDULED_CACHES,
false, false,

1
src/server-dev.ts
View File

@ -40,7 +40,6 @@ process.nextTick(async () => {
embedProxyFrontend: true, embedProxyFrontend: true,
anonymiseEventLog: false, anonymiseEventLog: false,
responseTimeWithAppNameKillSwitch: false, responseTimeWithAppNameKillSwitch: false,
userAccessUIEnabled: true,
outdatedSdksBanner: true, outdatedSdksBanner: true,
disableShowContextFieldSelectionValues: false, disableShowContextFieldSelectionValues: false,
feedbackPosting: true, feedbackPosting: true,