1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-13 13:48:59 +02:00

remove some unused things

This commit is contained in:
Thomas Heartman 2025-05-07 08:39:51 +02:00
parent 20a80142d3
commit ee0a453cc9

View File

@ -9,9 +9,7 @@ import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStr
interface IConstraintAccordionEditProps { interface IConstraintAccordionEditProps {
constraint: IConstraint; constraint: IConstraint;
onCancel?: () => void; onCancel?: () => void;
onSave: (constraint: IConstraint) => void;
onDelete?: () => void; onDelete?: () => void;
onAutoSave?: (constraint: IConstraint) => void;
} }
export const CANCEL = 'cancel'; export const CANCEL = 'cancel';
@ -38,16 +36,11 @@ const resolveContextDefinition = (
export const EditableConstraintWrapper = ({ export const EditableConstraintWrapper = ({
constraint, constraint,
onSave,
onDelete, onDelete,
onAutoSave,
}: IConstraintAccordionEditProps) => { }: IConstraintAccordionEditProps) => {
const [localConstraint, setLocalConstraint] = useState<IConstraint>( const [localConstraint, setLocalConstraint] = useState<IConstraint>(
cleanConstraint(constraint), cleanConstraint(constraint),
); );
const [constraintChanges, setConstraintChanges] = useState<IConstraint[]>([
cleanConstraint(constraint),
]);
const { context } = useUnleashContext(); const { context } = useUnleashContext();
const [contextDefinition, setContextDefinition] = useState( const [contextDefinition, setContextDefinition] = useState(
@ -60,26 +53,6 @@ export const EditableConstraintWrapper = ({
); );
}, [localConstraint.contextName, context]); }, [localConstraint.contextName, context]);
const onUndo = () => {
if (constraintChanges.length < 2) return;
const previousChange = constraintChanges[constraintChanges.length - 2];
setLocalConstraint(previousChange);
setConstraintChanges((prev) => prev.slice(0, prev.length - 1));
autoSave(previousChange);
};
const autoSave = (localConstraint: IConstraint) => {
if (onAutoSave) {
onAutoSave(localConstraint);
}
};
const recordChange = (localConstraint: IConstraint) => {
setConstraintChanges((prev) => [...prev, localConstraint]);
autoSave(localConstraint);
};
const setContextName = useCallback((contextName: string) => { const setContextName = useCallback((contextName: string) => {
setLocalConstraint((prev) => { setLocalConstraint((prev) => {
const localConstraint = cleanConstraint({ const localConstraint = cleanConstraint({
@ -89,8 +62,6 @@ export const EditableConstraintWrapper = ({
value: '', value: '',
}); });
recordChange(localConstraint);
return localConstraint; return localConstraint;
}); });
}, []); }, []);
@ -104,18 +75,6 @@ export const EditableConstraintWrapper = ({
value: '', value: '',
}); });
recordChange(localConstraint);
return localConstraint;
});
}, []);
const setValuesWithRecord = useCallback((values: string[]) => {
setLocalConstraint((prev) => {
const localConstraint = { ...prev, values };
recordChange(localConstraint);
return localConstraint; return localConstraint;
}); });
}, []); }, []);
@ -132,8 +91,6 @@ export const EditableConstraintWrapper = ({
setLocalConstraint((prev) => { setLocalConstraint((prev) => {
const localConstraint = { ...prev, value }; const localConstraint = { ...prev, value };
recordChange(localConstraint);
return localConstraint; return localConstraint;
}); });
}, []); }, []);
@ -142,8 +99,6 @@ export const EditableConstraintWrapper = ({
setLocalConstraint((prev) => { setLocalConstraint((prev) => {
const localConstraint = { ...prev, inverted: !prev.inverted }; const localConstraint = { ...prev, inverted: !prev.inverted };
recordChange(localConstraint);
return localConstraint; return localConstraint;
}); });
}; };
@ -155,8 +110,6 @@ export const EditableConstraintWrapper = ({
caseInsensitive: !prev.caseInsensitive, caseInsensitive: !prev.caseInsensitive,
}; };
recordChange(localConstraint);
return localConstraint; return localConstraint;
}); });
}, []); }, []);
@ -165,10 +118,8 @@ export const EditableConstraintWrapper = ({
(index: number) => { (index: number) => {
const valueCopy = [...localConstraint.values!]; const valueCopy = [...localConstraint.values!];
valueCopy.splice(index, 1); valueCopy.splice(index, 1);
setValuesWithRecord(valueCopy);
}, },
[localConstraint, setValuesWithRecord], [localConstraint],
); );
return ( return (
@ -180,7 +131,6 @@ export const EditableConstraintWrapper = ({
toggleInvertedOperator={setInvertedOperator} toggleInvertedOperator={setInvertedOperator}
toggleCaseSensitivity={setCaseInsensitive} toggleCaseSensitivity={setCaseInsensitive}
onDelete={onDelete} onDelete={onDelete}
onUndo={onUndo}
constraintChanges={constraintChanges} constraintChanges={constraintChanges}
setValues={setValues} setValues={setValues}
setValuesWithRecord={setValuesWithRecord} setValuesWithRecord={setValuesWithRecord}