Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: strategy targeting numeric also check value field (#6774)

Browse Source 
API returns both value and values fields. Empty values array causes ui
to think constraint doesnt have a value

This PR checks if value field exists and is empty before returning check
on values and length
This commit is contained in:
David Leek 2024-04-04 11:48:51 +02:00 committed by GitHub
parent 99a32a4265
commit f29ecaf3c0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/FeatureStrategyConstraints.tsx
View File

@ -18,7 +18,10 @@ interface IFeatureStrategyConstraintsProps {
}
const filterConstraints = (constraint: any) => {
if (constraint.hasOwnProperty('values')) {
if (
constraint.hasOwnProperty('values') &&
(!constraint.hasOwnProperty('value') || constraint.value === '')
) {
return constraint.values && constraint.values.length > 0;
}