Nicolae Socaciu
9f72030578
Updated scheduled-change-conflict ( #5908 )
...
Updating the UI of the email template
Closes #
[1-1940](https://linear.app/unleash/issue/1-1940/improve-scheduled-change-conflict-template )
Before
After:
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: andreas-unleash <andreas@getunleash.ai>
2024-01-16 16:12:25 +02:00
Mateusz Kwasniewski
f6c0624869
feat: prevent double daily metrics insert ( #5906 )
2024-01-16 13:52:56 +01:00
Mateusz Kwasniewski
af4c3a86d1
fix: should not import archived child and parent ( #5912 )
2024-01-16 13:42:25 +01:00
Gastón Fournier
9989688d36
chore: missing export ( #5911 )
...
## About the changes
Overlooked on https://github.com/Unleash/unleash/pull/5910
2024-01-16 13:35:57 +01:00
Gastón Fournier
2ddc56927e
chore: centralize events service creation ( #5910 )
...
## About the changes
EventsService is a dependency in most of our services. This creates
helper methods to create them easily and replace a few places where
we're creating them manually
2024-01-16 13:11:28 +01:00
Gastón Fournier
317e0e7ecd
feat: event types for actions ( #5907 )
...
Define event types for actions
2024-01-16 11:59:09 +01:00
Nuno Góis
aeb9c85f11
chore: delete unnecessary column permission_id ( #5413 )
...
Follows up on https://github.com/Unleash/unleash/pull/5409 and drops
this column, since it's no longer used.
See: https://github.com/Unleash/unleash/pull/5409#discussion_r1404112310
Should only be merged after ~~`5.7`~~ `5.8` has been released.
2024-01-16 10:56:22 +00:00
Thomas Heartman
6e234727ee
chore: align with system user in db ( #5893 )
...
This change removes the system user's email from the definition, instead
setting it to `null`. It also changes the name to "Unleash System".
The IUser interface doesn't allow `null` email addresses, so we change
the type definition of the system user to get around it. However, using
`null` (instead of just removing the property entirely) is useful
because when you get the system user from the DB, it's email value will
be null (after it has been nulled out).
As of today, there is nowhere in the Unleash system (OSS or Enterprise)
where we use the system user as an IUser (we only use username and ID).
So this change shouldn't break anything.
This should follow https://github.com/Unleash/unleash/pull/5849 .
2024-01-16 05:49:54 +00:00
Thomas Heartman
4564c97927
chore: remove system user's email in db. ( #5849 )
...
Updates it from 'system@getunleash.io' to `null`. We don't have that
address registered (and probably don't want it), so we'll leave it
empty.
This is a companion PR to
https://github.com/Unleash/unleash/pull/5893 . With both of those
merged, the system user in the DB should match the one defined in
`core.ts`
2024-01-16 11:15:29 +05:30
Mateusz Kwasniewski
65eb8956e1
feat: Prometheus last day metrics ( #5878 )
2024-01-15 15:31:38 +01:00
Mateusz Kwasniewski
3e186f1986
chore: remove schedulers ( #5895 )
2024-01-15 15:10:15 +01:00
Nuno Góis
1c84a81178
fix: include custom root roles in user access overview ( #5898 )
...
https://linear.app/unleash/issue/2-1844/fix-add-custom-root-roles-to-user-access-overview
I noticed our user access overview method did not take into account
custom root roles, which meant only users with default root roles were
being returned.
This changes the query to check for `IN ('root', 'root-custom')`
instead, including both "root" and "custom root" roles.
2024-01-15 13:38:31 +00:00
Nuno Góis
0ba37e8622
feat: list all root roles in SSO config ( #5887 )
...
Lists all root roles in SSO config, including custom root roles.
2024-01-15 13:13:29 +00:00
Christopher Kolstad
9d839299e2
fix: differentiated interval and initial schedule call ( #5896 )
...
Differentiate log lines so we can see if it happens on every call, or
just on the initial call.
2024-01-15 11:50:32 +00:00
Mateusz Kwasniewski
8eb5a53ad9
feat: metrics calculation limit ( #5853 )
2024-01-12 12:32:31 +01:00
Christopher Kolstad
5a3bb1ffc3
Biome1.5.1 ( #5867 )
...
Lots of work here, mostly because I didn't want to turn off the
`noImplicitAnyLet` lint. This PR tries its best to type all the untyped
lets biome complained about (Don't ask me how many hours that took or
how many lints that was >200...), which in the future will force test
authors to actually type their global variables setup in `beforeAll`.
---------
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
2024-01-12 09:25:59 +00:00
Mateusz Kwasniewski
e27a578fab
feat: separate UI flag and backend flag for extended metrics ( #5875 )
2024-01-12 10:20:03 +01:00
Gastón Fournier
79d438ac46
feat: add automated actions tables ( #5857 )
...
Add tables to support automated actions based on the [design
document](https://docs.google.com/document/d/15xPgn6B8gzMPk9RjMAUGu8XvozQ_45jjrsVl_Bm6Chg/edit?usp=sharinghttps://docs.google.com/document/d/15xPgn6B8gzMPk9RjMAUGu8XvozQ_45jjrsVl_Bm6Chg/edit?usp=sharing )
2024-01-11 14:42:37 +01:00
Nuno Góis
b496990f79
chore: add no unused imports biome rule ( #5855 )
...
Adds a Biome rule for "no unused imports", which is something we
sometimes have trouble catching.
We're adding this as a warning for now. It is safely and easily fixable
with `yarn lint:fix`.
2024-01-11 12:44:05 +00:00
andreas-unleash
6ae6193d3f
chore: remove unused event ( #5854 )
...
Removes the SCHEDULED_CHANGE_REQUEST_EXECUTED event - replaced with
CHANGE_REQUEST_SCHEDULED_APPLICATION_FAILURE,
CHANGE_REQUEST_SCHEDULED_APPLICATION_SUCCESS events
Closes #
[1-1900](https://linear.app/unleash/issue/1-1900/remove-old-schedule-executed-event )
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2024-01-11 13:59:44 +02:00
Thomas Heartman
3779a6f0fb
Revert "chore: align the system user defined in core.ts with the one created in the migration ( #5845 )" ( #5852 )
...
This reverts commit 0b5ac19d9a
2024-01-11 15:31:15 +05:30
Mateusz Kwasniewski
ca3b4c5057
feat: Metrics api returning daily data ( #5830 )
2024-01-11 10:39:41 +01:00
Thomas Heartman
0b5ac19d9a
chore: align the system user defined in core.ts with the one created in the migration ( #5845 )
...
This change adjusts the exported `SYSTEM_USER` constant in `core.ts` to
match the one created in the migration in
`src/migrations/20231222071533-unleash-system-user.js`
The slight discrepancy between these two caused me some minor headache
when trying to write a test in enterprise.
It also removes the email because we have no inbox at that address (and
we probably don't want one).
For reference, the migration looks like this:
``` sql
ALTER TABLE users ADD COLUMN IF NOT EXISTS is_system BOOLEAN NOT NULL DEFAULT FALSE;
INSERT INTO users
(id, name, username, email, created_by_user_id, is_system)
VALUES
(-1337, 'Unleash System', 'unleash_system_user', 'system@getunleash.io', -1337, true);
```
2024-01-11 15:08:59 +05:30
Christopher Kolstad
e7642c02aa
feat: Added bulk metrics support under /api/client/metrics/bulk path ( #5779 )
...
This adds a bulk endpoint under `/api/client/metrics`. Accessible under
`/api/client/metrics/bulk`.
This allows us to piggyback on the need for an API user with access.
This PR mostly copies the behaviour from our `/edge/metrics` endpoint,
but it filters metrics to only include the environment that the token
has access to.
So a client token that has access to the `production` will not be
allowed to report metrics for the `development` environment. More
importantly, a `development` token will not be allowed to post metrics
for the `production` environment.
2024-01-10 14:52:34 +01:00
Mateusz Kwasniewski
d71108526e
feat: read extended metrics from more than 48 hours ( #5822 )
2024-01-10 11:48:06 +01:00
Thomas Heartman
336eab9c5a
feat: allow slack-app and webhook to listen to schedule suspended events ( #5821 )
...
This PR adds the schedule suspended event to the slack-app and webhook
definitions.
It also slightly tweaks the markdown formatting of change requests to
add a definite article. This means the snapshot also needs to be
updated.
2024-01-10 15:14:31 +05:30
renovate[bot]
92ae2235a0
chore(deps): update dependency @biomejs/biome to v1.4.1 ( #5709 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@biomejs/biome](https://biomejs.dev )
([source](https://togithub.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome ))
| [`1.4.0` ->
`1.4.1`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/1.4.0/1.4.1 )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>biomejs/biome (@​biomejs/biome)</summary>
###
[`v1.4.1`](https://togithub.com/biomejs/biome/blob/HEAD/CHANGELOG.md#141-2023-11-30 )
[Compare
Source](889593e3f9...a887513062https://togithub.com/biomejs/biome/issues/933 ). Some
files are properly ignored in the LSP too. E.g. `package.json`,
`tsconfig.json`, etc.
##### Formatter
##### Bug fixes
- Fix some accidental line breaks when printing array expressions within
arrow functions and other long lines
[#​917](https://togithub.com/biomejs/biome/pull/917 ). Contributed
by [@​faultyserver](https://togithub.com/faultyserver )
- Match Prettier's breaking strategy for `ArrowChain` layouts
[#​934](https://togithub.com/biomejs/biome/pull/934 ). Contributed
by [@​faultyserver](https://togithub.com/faultyserver )
- Fix double-printing of leading comments in arrow chain expressions
[#​951](https://togithub.com/biomejs/biome/pull/951 ). Contributed
by [@​faultyserver](https://togithub.com/faultyserver )
##### Linter
##### Bug fixes
- Fix [#​910](https://togithub.com/biomejs/biome/issues/910 ),
where the rule `noSvgWithoutTitle` should skip elements that have
`aria-hidden` attributes. Contributed by
[@​vasucp1207](https://togithub.com/vasucp1207 )
##### New features
- Add [useForOf](https://biomejs.dev/linter/rules/use-for-of ) rule.
The rule recommends a for-of loop when the loop index is only used to
read from an array that is being iterated.
Contributed by [@​victor-teles](https://togithub.com/victor-teles )
##### Enhancement
- Implements
[#​924](https://togithub.com/biomejs/biome/issues/924 ) and
[#​920](https://togithub.com/biomejs/biome/issues/920 ).
[noUselessElse](https://biomejs.dev/linter/rules/no-useless-else ) now
ignores `else` clauses that follow at least one `if` statement that
doesn't break early. Contributed by
[@​Conaclos](https://togithub.com/Conaclos )
For example, the following code is no longer reported by the rule:
```js
function f(x) {
if (x < 0) {
// this `if` doesn't break early.
} else if (x > 0) {
return x;
} else {
// This `else` block was previously reported as useless.
}
}
```
##### Bug fixes
- Fix [#​918](https://togithub.com/biomejs/biome/issues/918 ),
[useSimpleNumberKeys](https://biomejs.dev/linter/rules/use-simple-number-keys )
no longer repports false positive on comments. Contributed by
[@​kalleep](https://togithub.com/kalleep )
- Fix [#​953](https://togithub.com/biomejs/biome/issues/953 ),
[noRedeclare](https://biomejs.dev/linter/rules/no-redeclare ) no longer
reports type parameters with the same name in different mapped types as
redeclarations. Contributed by
[@​Conaclos](https://togithub.com/Conaclos )
- Fix [#​608](https://togithub.com/biomejs/biome/issues/608 ),
[useExhaustiveDependencies](https://biomejs.dev/linter/rules/use-exhaustive-dependencies )
no longer repports missing dependencies for React hooks without
dependency array. Contributed by
[@​kalleep](https://togithub.com/kalleep )
##### Parser
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Leek <david@getunleash.io>
2024-01-10 09:11:49 +00:00
Mateusz Kwasniewski
2c0c4e70ea
feat: Schedule daily metrics deletion ( #5807 )
2024-01-10 08:52:40 +01:00
Thomas Heartman
920e80c17e
chore: add schedule suspended event type ( #5820 )
...
To facilitate emitting this event in Enterprise
2024-01-10 13:21:11 +05:30
renovate[bot]
51e2d3ed46
chore(deps): update dependency node to v18.19.0 ( #4957 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change | Pending | Age | Adoption | Passing
| Confidence |
|---|---|---|---|---|---|---|---|---|
| [node](https://togithub.com/nodejs/node ) | | minor | `18.18.0` ->
`18.19.0` | |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
|
[@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node )
([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node ))
| devDependencies | minor | [`18.17.19` ->
`18.19.4`](https://renovatebot.com/diffs/npm/@types%2fnode/18.17.19/18.19.4 )
| `18.19.6` (+1) |
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
[](https://docs.renovatebot.com/merge-confidence/ )
|
---
### Release Notes
<details>
<summary>nodejs/node (node)</summary>
###
[`v18.19.0`](https://togithub.com/nodejs/node/compare/v18.18.2...v18.19.0 )
[Compare
Source](https://togithub.com/nodejs/node/compare/v18.18.2...v18.19.0 )
###
[`v18.18.2`](https://togithub.com/nodejs/node/compare/v18.18.1...v18.18.2 )
[Compare
Source](https://togithub.com/nodejs/node/compare/v18.18.1...v18.18.2 )
###
[`v18.18.1`](https://togithub.com/nodejs/node/releases/tag/v18.18.1 ):
2023-10-10, Version 18.18.1 'Hydrogen' (LTS),
@​richardlau
[Compare
Source](https://togithub.com/nodejs/node/compare/v18.18.0...v18.18.1 )
##### Notable Changes
This release addresses some regressions that appeared in Node.js
18.18.0:
- (Windows) FS can not handle certain characters in file name
[#​48673](https://togithub.com/nodejs/node/issues/48673 )
- 18 and 20 node images give error - Text file busy (after re-build
images)
[nodejs/docker-node#1968 ](https://togithub.com/nodejs/docker-node/issues/1968 )
- libuv update in 18.18.0 breaks webpack's thread-loader
[#​49911](https://togithub.com/nodejs/node/issues/49911 )
The libuv 1.45.0 and 1.46.0 updates that were released in Node.js
18.18.0 have been temporarily reverted.
##### Commits
- \[[`3e3a75cc46`](https://togithub.com/nodejs/node/commit/3e3a75cc46 )]
- ***Revert*** "**build**: sync libuv header change" (Richard Lau)
[#​50036](https://togithub.com/nodejs/node/pull/50036 )
- \[[`14ece2c479`](https://togithub.com/nodejs/node/commit/14ece2c479 )]
- ***Revert*** "**deps**: upgrade to libuv 1.45.0" (Richard Lau)
[#​50036](https://togithub.com/nodejs/node/pull/50036 )
- \[[`022352acbe`](https://togithub.com/nodejs/node/commit/022352acbe )]
- ***Revert*** "**deps**: upgrade to libuv 1.46.0" (Richard Lau)
[#​50036](https://togithub.com/nodejs/node/pull/50036 )
- \[[`d9f138189c`](https://togithub.com/nodejs/node/commit/d9f138189c )]
- ***Revert*** "**deps**: add missing thread-common.c in uv.gyp"
(Richard Lau)
[#​50036](https://togithub.com/nodejs/node/pull/50036 )
- \[[`7a3e1ffbb8`](https://togithub.com/nodejs/node/commit/7a3e1ffbb8 )]
- **fs**: make sure to write entire buffer (Robert Nagy)
[#​49211](https://togithub.com/nodejs/node/pull/49211 )
- \[[`04cba95a67`](https://togithub.com/nodejs/node/commit/04cba95a67 )]
- **test**: add `tmpdir.resolve()` (Livia Medeiros)
[#​49079](https://togithub.com/nodejs/node/pull/49079 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 7pm every weekday,before 5am
every weekday" in timezone Europe/Madrid, Automerge - At any time (no
schedule defined).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/Unleash/unleash ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Ivar Conradi Østhus <ivar@getunleash.ai>
2024-01-10 07:23:19 +00:00
Thomas Heartman
e8ffea3920
chore: add reason column to change request schedule table ( #5802 )
...
This PR adds a new `reason` column to the change request schedules table
and populates it with the data that is in the `failure_reason` column.
This is the expand phase of the expand/contract pattern. The code in
enterprise will be updated to try and use the new column name, but fall
back to the old one if no value is present.
The old column can be removed later.
2024-01-10 08:47:30 +05:30
Ivar Conradi Østhus
6d4a727bdf
fix: remove unsued metric 'optimal304DiffingCounter' ( #5810 )
...
This metric was used while developing the optimal304 feature. The
feature flag has been removed and this data is not longer being
collected and this will remove the metric from Prometheus.
2024-01-09 18:54:28 +01:00
Gard Rimestad
24b202ef0b
feat: include environment type label in feature_toggle_update metrics ( #5809 )
...
This is needed in order to identify what type of an environment a toggle
is updated in. This can be test, development, pre-production or
production.
2024-01-09 16:33:00 +01:00
Mateusz Kwasniewski
a1b04e4b8d
feat: Aggregate daily metrics ( #5804 )
2024-01-09 13:46:49 +01:00
Gard Rimestad
adc47fd778
feat: add db metrics for environment-store ( #5808 )
...
This will give us prometheus metrics on environment lookups in the
database
2024-01-09 13:17:16 +01:00
Gastón Fournier
eb7882e2eb
feat: add automated actions flag ( #5805 )
...
Just a flag for an enterprise feature
2024-01-09 11:42:28 +00:00
Mateusz Kwasniewski
99b165741d
feat: daily metrics db migration ( #5791 )
2024-01-09 11:56:12 +01:00
Nuno Góis
24b4e8dcb2
chore: incoming webhooks description migration ( #5803 )
...
https://linear.app/unleash/issue/2-1822/incoming-webhooks-add-description
A description field will help us better distinguish incoming webhooks
and their purpose.
2024-01-09 10:39:51 +00:00
Mateusz Kwasniewski
8955a9906d
feat: extended metrics options ui ( #5786 )
2024-01-08 14:49:41 +01:00
Gastón Fournier
1724219487
feat: encrypt emails at rest for demo login ( #5759 )
...
## About the changes
This allows us to encrypt emails at signup for demo users to further
secure our demo instance. Currently, emails are anonymized before
displaying events performed by demo users. But this means that emails
are stored at rest in our DB. By encrypting the emails at login, we're
adding another layer of protection.
This can be enabled with a flag and requires the encryption key and the
initialization vector (IV for short) to be present as environment
variables.
2024-01-05 14:21:20 +01:00
Christopher Kolstad
e769ceab05
task: Add an X-Unleash-Version header to register response ( #5774 )
...
Related to our work for making Edge bulk metrics a 1st class citizen of
Unleash, this PR adds an X-Unleash-Version header to the response from
client registration.
Based on when we add the new `/api/client/metrics/bulk` endpoint, Edge
can use the response header from upstream to decide whether to post
metrics to `/edge/metrics` or `/api/client/metrics/bulk`.
2024-01-05 11:54:28 +01:00
Jaanus Sellin
75e81515c8
chore: disable search feedback by default ( #5767 )
2024-01-04 14:44:17 +00:00
Christopher Kolstad
4c574a1e50
task: add kill-switch for edge bulk metrics ( #5758 )
...
If the kill switch is enabled unleash returns 404 and a json body explaining why a 404 was given, encouraging users to upgrade to the most recent version of Edge.
2024-01-04 11:21:48 +01:00
Fredrik Strand Oseberg
70600552d2
Feat/add feedback to new strategy form ( #5745 )
...
This PR adds the feedback form to the new create / edit strategy form
behind a feature flag.
* Add feedback form
* Minor refactor to useFeedback
2024-01-03 15:43:22 +01:00
Ivar Conradi Østhus
31124e4a90
fix: add feature-flag for license
2024-01-03 15:25:54 +01:00
Jaanus Sellin
a73d87a943
feat: make feedback available for OSS ( #5748 )
2024-01-03 15:08:01 +02:00
Nuno Góis
9c4a044543
chore: observable events db migration ( #5749 )
...
https://linear.app/unleash/issue/2-1773/db-create-migration-for-a-new-observable-events-table
Adds a new DB migration to create a new `observable_events` table. Even
though we are thinking long term with the `source` columns, the short
term purpose of this table will be to store incoming webhook calls.
2024-01-03 12:08:14 +00:00
Gastón Fournier
2a1c0616e0
feat: support null created_by_user_id ( #5744 )
...
## About the changes
Creating an incoming webhook with an admin token means we can't
correlate the action with a real user. In this case we should support
null.
2024-01-02 17:53:29 +01:00
Christopher Kolstad
e993846471
task: add timer for client feature query ( #5734 )
...
Adds a database query timer for the client features query.
2024-01-02 16:02:03 +01:00
Jaanus Sellin
dc0df235dd
chore: remove private projects flag ( #5743 )
2024-01-02 15:53:26 +02:00
