1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-10-18 20:09:08 +02:00
Commit Graph

408 Commits

Author SHA1 Message Date
Youssef
54d39882c3 create environment guidance dialog 2021-12-06 12:27:01 +01:00
Thomas Heartman
dd1ab1ca72 Autofocus dialog form fields, allow form submissions via pressing enter inside the form (#524)
* chore: add prettier as a dev dependency

The project has a .prettierrc, so seems to depend on that for its
formatting, but there was no prettier installed with the node modules.

* chore: add autofocus to all clearly defined first inputs on dialogs.

* fix: wrap the disable env input in a form and give it autofocus.

* fix: submit form when pressing enter

* fix: only autofocus the submit button if there is no other content.

When multiple (enabled) elements have the autofocus attribute, the
browser picks the last element in the tree. This means that if there
is a form with a text input with autofocus and a submit button with
autofocus, the button will win, causing the user to have to tab back up.

Only doing this if there are no children will cause some changes,
however:

Dialogs with textual children will no longer focus the accept-button
when appearing.

However, dialogs such as the create new api token dialog will give the
focus to the first input field instead of to the create button.

* fix: add formId prop to dialog element; adapt behavior

If the component receives a form id, it will treat the primary button
as the submit button for that form. To stop a full page reload, we
call the `preventDefault` on the submit event before calling the handler.

* chore: remove redundant spacing in component.

* fix: hook environment disable form up with the new form id system.

* chore: Update existing modal forms to pass in formId

* fix: Type the dialog event wrapper

* fix: change 'allows' => 'allow' because the noun is pluralized.

* fix: add autofocus to js add-tag-dialog-component.

I've got a feeling this component isn't in use anymore, though, as the
exact same text appears in a TS-version of this component.

* fix: add autofocus to add user form.

This seems to only be used as the main piece of a modal, so adding
autofocus seems pretty safe here, but I could be wrong.

* fix: Update snapshot test after changing wording.

* fix: add autofocus to update user form

* fix: add autofocus to the create toggle form.

This is a little besides the task's actual point. However! This form
is only ever used on the page where it's the only bit of content. I'd
argue that when the user navigates to this form, it's because they
want to create a feature. Thus, adding autofocus to the first field
makes a lot of sense to me.

* refactor: set button type to 'undefined' when it isn't 'submit'

This allows Material to use their default type based on whatever
heuristics they use. It's most likely going to be 'button' for the
foreseeable future, but in the event that they change it, passing
undefined instead should future-proof this a bit.

* fix: set type to button when formId is not present

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-11-29 15:18:12 +01:00
Youssef Khedher
165170cd5c fix/breadcrumb (#533)
* fix: remove features2 from breadcrumb

* fix: strategy names

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2021-11-29 14:29:58 +01:00
sighphyre
b85b326104 task: Add buttons for deleting/editing a constraint (#522)
* task: Add buttons for deleting/editing a constraint

* task: Improve look and feel of constraints buttons

- Make constraints fill their container
- Move constraint buttons to material ui buttons
- Move constraint buttons to top right of their container

* fix: adjust positioning

* fix: added project id to permissin button

* fix: add correct permission

* fix: update create feature path

Co-authored-by: Simon Hornby <simon@getunleash.ai>
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2021-11-26 16:07:05 +01:00
sighphyre
3e53a64fcf fix: Remove edit click handler from variants list (#528)
Co-authored-by: Simon Hornby <simon@getunleash.ai>
2021-11-26 15:29:51 +01:00
Youssef Khedher
f2a85ebf79 fix/strategy tab (#519)
* fix: add the toggle switch inside the strategies list

* fix: styling strategy execution tab

* fix: remove visual execution from strategy tab

* fix: test fail on yarn build

* fix: add style for the strategy container

* fix: remove overlapping of switch

* fix: remove border from select strategy

* fix: remove borders and adjust icon rollout

* fix: use theme grey

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-11-26 13:36:04 +01:00
Simon Hornby
116a8e73f7 Merge branch 'master' into fix/variant-list-popup 2021-11-26 09:32:59 +02:00
Simon Hornby
e5c941c68d Fix variant list
- Fix an issue where clicking a variant in the list would popup a modal
dialog with empty details
2021-11-25 16:02:38 +02:00
Christopher Kolstad
83443627d9 feat: Use new Variants API (#518)
* feat: Use new Variants API

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-11-25 14:05:44 +01:00
Fredrik Strand Oseberg
dd2b661928 Merge branch 'master' into fix/search-field 2021-11-24 14:43:01 +01:00
Fredrik Strand Oseberg
36fcac7178 Fix/project view desc (#515)
* fix: rollout icon and disabled state

* fix: mobile position

* refactor: move into style file

* fix: description box for projects

* fix: icon placement

* fix: icon

* fix: mobile project view

* fix: add style file to disabled indicator

* fix: hide icon on mobile

* fix: description

* fix: remove project logo
2021-11-24 14:36:21 +01:00
Youssef
64aa5bde06 fix: clear search input on route change 2021-11-24 11:41:43 +01:00
Fredrik Strand Oseberg
47bfda1f7b fix: constraints scrollbars (#504) 2021-11-22 11:32:43 +01:00
Fredrik Strand Oseberg
1dd6e1d65c fix: mobile percentagecircle (#502) 2021-11-12 12:41:36 +01:00
Fredrik Strand Oseberg
3465f4c664 fix: status chip (#501) 2021-11-12 12:02:47 +01:00
Fredrik Strand Oseberg
c0da8ed6bc Feat/new toggle overview (#497)
* feat: toggle overview accordions

* feat: accordion metrics

* feat: result

* add permission button

* fix: remove feature environment container from strategies tab

* chore: delete unused code

* fix: remove console log

* fix: remove unused code

* fix: cleanup

* fix: refactor

* fix: add empty states

* fix: loading

* feat: mobile accordions

* fix: button

* fix: strategies

* fix: cleanup

* fix: remove unused params

* fix: strategy button container

* fix: alter gradual rollout id

* fix: update userid strategy item

* fix: string truncator

* fix: strategy link

* fix: strategies tab

* fix: remove unused imports

* fix: visual improvements

* fix: add border
2021-11-12 11:47:19 +01:00
Youssef
8d38b5cd7f fix: rename isProjectDeleted to projectExists and add PermissionIconButton 2021-11-08 10:22:37 +01:00
Youssef
64481e9c51 update snapshots 2021-11-05 23:35:44 +01:00
Youssef
9cc1e56f13 fix: disable revive feature when project is deleted 2021-11-05 23:21:21 +01:00
Youssef
1e47975dc8 use useProjects to check if project deleted or not 2021-11-05 10:14:52 +01:00
Youssef
7d2ea9407c fix: remove typo from UI 2021-11-05 09:19:07 +01:00
Youssef Khedher
e839155f48 Fix/strategy sidepanel (#479)
* make addButton color white when hover on strategy card

* fix: change arrow in side panel

* make sidepanel button responsive

* add ellipse to icons in sidepanel

* remove important property from css

* remove ellipse from disabled icons

* fix navigation with tab for features list in project view

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-11-04 14:40:09 +01:00
Youssef
0ad287f383 use color from palette and add highlight feat for other components 2021-11-01 23:43:55 +01:00
Youssef
3e07c4f989 add highlight to table rows for features 2021-11-01 14:28:44 +01:00
Youssef Khedher
81b82c368a update text in the drop area (#482) 2021-11-01 12:03:15 +01:00
Youssef Khedher
3ba502a3c7 fix: remove semicolon from component (#480) 2021-10-29 21:14:38 +02:00
Youssef Khedher
ed6efff643 Fix/variants: Fix delete one variant + remove switch when add first variant (#466)
Co-authored-by: Ivar Conradi Østhus <ivarconr@gmail.com>
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2021-10-28 13:32:29 +02:00
Youssef Khedher
d599cc55e4 make addButton color white when hover on strategy card (#467)
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-10-27 17:22:23 +02:00
Ivar Conradi Østhus
2c56f89bf2 fix: update link to environment-docs 2021-10-26 12:48:56 +02:00
Youssef Khedher
35670db919 edit project mismatch dialog and remove change button (#465)
* edit project mismatch dialog and remove change button

* add info test to solve mismatch
2021-10-25 12:47:15 +02:00
Fredrik Strand Oseberg
13884db360 Fix/cache (#461)
* fix: set strategy cache when mounting

* fix: add permission button

* fix: add permission button for discard

* fix: button type

* fix: unused imports

* fix: move setDirty

* fix: add clone deep
2021-10-22 13:38:36 +02:00
Youssef Khedher
cb0735a7a3 Merge branch 'master' into fix/clone-toggle-crash 2021-10-22 09:48:19 +01:00
Fredrik Oseberg
6a8cc1adf5 fix: pie size 2021-10-22 10:45:43 +02:00
Youssef Khedher
5e7c692e9c Merge branch 'master' into fix/clone-toggle-crash 2021-10-21 22:22:34 +01:00
Youssef
f2879cea79 disable clone button based on role in old view 2021-10-21 22:03:38 +01:00
Christopher Kolstad
83ad4041bf fix: Adds PermissionSwitch (#456)
- This adds a generic way to control permission to mutations in the same
  way as our PermissionButton and PermissionIconButton already does the
  same.

- This also switches the StrategiesList to use PermissionIconButton so
  users without ADMIN role do not believe they can deprecate/reactivate
  strategies.
2021-10-21 13:25:39 +02:00
Ivar Conradi Østhus
0ddd52a8ba fix: adjust tooltip for toggle type 2021-10-21 10:41:46 +02:00
Fredrik Strand Oseberg
fea7707551 fix: use path parameter for old ft view (#450)
* fix: use path parameter for old ft view

* fix: update snapshots

* fix: change text

* fix: add permission button to initial strategies view

* fix: remove unused imports
2021-10-21 09:50:58 +02:00
Fredrik Oseberg
c763b80569 fix: style import 2021-10-20 13:40:08 +02:00
Fredrik Oseberg
5d48ce3f03 fix: margin 2021-10-20 13:21:39 +02:00
Ivar Conradi Østhus
03230fcff9 fix: failing unit tests 2021-10-20 13:20:10 +02:00
Fredrik Oseberg
73861b0f2e fix: metrics styling 2021-10-20 13:18:33 +02:00
Fredrik Oseberg
37d04b56ba fix: scale metrics 2021-10-20 13:15:32 +02:00
Youssef Khedher
2bce93a51b Fix: improve create new feature v2 (#441) 2021-10-20 13:12:48 +02:00
Fredrik Strand Oseberg
48bae48ee0 fix: style metrics view (#448) 2021-10-20 12:55:40 +02:00
Fredrik Strand Oseberg
57928d50c6 Fix/environment list sorting (#447)
* fix: wait for api call before refetching

* fix: set active environment from feature instead of cache

* fix: remove console logs

* fix: add permission icon button to project card

* fix: remove project button

* fix: empty tooltip if it is not passed

* fix: add refresh interval

* fix: permission buttons

* fix: project permission buttons

* fix: remove unused imports

* fix: add projectId
2021-10-20 12:05:44 +02:00
Youssef Khedher
3dc7f22aaa fix switch toggle for envs after update + update link for health overview (#446)
* fix switch toggle for envs after update

* fix: React hook missing dependency error
2021-10-19 15:38:20 +02:00
Fredrik Strand Oseberg
005daa3740 Fix/login redirect (#442)
* fix: use swr with login

* fix: remove metrics poller

* fix: do not allow retry on 401

* fix: create swr provider

* fix: move accessprovider

* fix: remove metrics poller test

* fix: hide password auth if disableDefault is set

* Update src/component/project/ProjectList/ProjectList.tsx

Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>

* fix: console log

Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
2021-10-19 13:08:25 +02:00
Christopher Kolstad
ea2086a7f4 Mutate cache key for project when archiving feature. (#444)
* Use useProject hook directly instead of mutating on cache key
2021-10-19 12:36:51 +02:00
Youssef
bdc4b3cf7a fix: truncate link in body and in breadcrumb 2021-10-15 16:27:55 +02:00