Nuno Góis
4d1f76e61b
fix: take into account project segments permission ( #5304 )
...
https://linear.app/unleash/issue/SR-164/ticket-1106-user-with-createedit-project-segment-is-not-able-to-edit-a
Fixes a bug where the `UPDATE_PROJECT_SEGMENT` permission is not
respected, both on the UI and on the API. The original intention was
stated
[here](https://github.com/Unleash/unleash/pull/3346#discussion_r1140434517 ).
This was easy to fix on the UI, since we were simply missing the extra
permission on the button permission checks.
Unfortunately the API can be tricky. Our auth middleware tries to grab
the `project` information from either the params or body object, but our
`DELETE` method does not contain this information. There is no body and
the endpoint looks like `/admin/segments/:id`, only including the
segment id.
This means that, in the rbac middleware when we check the permissions,
we need to figure out if we're in such a scenario and fetch the project
information from the DB, which feels a bit hacky, but it's something
we're seemingly already doing for features, so at least it's somewhat
consistent.
Ideally what we could do is leave this API alone and create a separate
one for project segments, with endpoints where we would have project as
a param, like so:
`http://localhost:4242/api/admin/projects/:projectId/segments/1 `.
This PR opts to go with the quick and hacky solution for now since this
is an issue we want to fix quickly, but this is something that we should
be aware of. I'm also unsure if we want to create a new API for project
segments. If we decide that we want a different solution I don't mind
either adapting this PR or creating a follow up.
2023-11-09 09:37:47 +00:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Nuno Góis
71f6b8e172
fix: revert form section 100 height ( #3345 )
...
Small fix that reverts
https://github.com/Unleash/unleash/pull/3335/files#r1138829014 - Turns
out it wasn't totally harmless and broke some modals that had more than
100% height and no overflow.
This approach maintains the original logic and adds a new prop for the
segment forms to make them proper modals when used in the project
context.
2023-03-17 13:59:46 +00:00
Nuno Góis
292d6a7f60
feat: implement project-scoped segments in project settings ( #3335 )
...
https://linear.app/unleash/issue/2-743/have-a-project-specific-configuration-section
Adds the "segments" option to project settings, providing the usual CRUD
operations but scoped to the specific project.
2023-03-17 08:23:27 +00:00
Nuno Góis
ff7185fe5b
feat: allow adding project to segment ( #3290 )
...
https://linear.app/unleash/issue/2-741/add-project-dropdown-into-creation-of-segments
Allows users to bind a segment to a project when creating or editing a
segment.
<img width="1051" alt="image"
src="https://user-images.githubusercontent.com/14320932/224103846-1fe1f849-496c-4a77-9831-53bcb36f822e.png ">
2023-03-10 08:16:54 +00:00
sjaanus
b631618532
Makestyles refactor #7/1 ( #2805 )
2023-01-03 16:30:59 +02:00
Tymoteusz Czech
c0b52fa672
Fix: UI improvements ( #1114 )
...
* fix: segments table author column width
* fix: update feature form ui
* fix: strategies breadcrumbs
* fix: api token page title
* fix: deprecated strategy label color
* fix: project access remove user toast
* fix: addon enable toast message
* fix: ces from ui
* fix: ui improvements with dialog typography
* fix: revert ces
* fix: change password error type
2022-06-28 12:58:10 +02:00
olav
006b853f6c
refactor: get segment limits from uiConfig ( #1047 )
...
* refactor: improve useUiConfig return type
* refactor: get segment limits from uiConfig
2022-06-02 10:58:55 +02:00
olav
d8143c6ff4
chore: update react-router to v6 ( #946 )
...
* refactor: fix child selector warnings
* refactor: update react-router-dom
* refactor: use BrowserRouter as in react-router docs
* refactor: replace Redirect with Navigate
* refactor: replace Switch with Routes
* refactor: replace useHistory with useNavigate
* refactor: replace useParams types with useRequiredPathParam
* refactor: replace NavLink activeStyle with callback
* refactor: fix matchPath arg order
* refactor: Remove unused link state
* refactor: delete broken snapshot test
* refactor: render 404 page without redirect
* refactor: normalize path parameter names
* refactor: fix Route component usage
2022-05-05 13:42:18 +02:00
olav
774157b8d7
refactor: fix segment permission checks ( #930 )
...
* refactor: use DELETE_SEGMENT permission in segments list
* refactor: clean up segment form mode prop
* refactor: format file
* refactor: fix ConstraintAccordion permission checks
2022-04-29 14:53:28 +02:00
olav
1fd6f2a60a
refactor: improve the text for docs links ( #904 )
...
* refactor: improve the text for docs links
* Update src/component/admin/apiToken/CreateApiToken/CreateApiToken.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/projectRoles/CreateProjectRole/CreateProjectRole.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/projectRoles/EditProjectRole/EditProjectRole.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/users/CreateUser/CreateUser.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/users/EditUser/EditUser.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/context/CreateUnleashContext/CreateUnleashContext.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/context/EditContext/EditContext.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/strategies/CreateStrategy/CreateStrategy.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/strategies/EditStrategy/EditStrategy.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* refactor: improve docs link texts
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-04-25 09:36:23 +02:00
olav
49b8e7329e
refactor: convert auth tests from Cypress to Jest ( #864 )
...
* refactor: replace data-test with data-testid
* refactor: add Jest tests for auth pages
* refactor: remove Cypress tests for auth pages
* refactor: remove questionable snapshots
* refactor: share test server setup/teardown
* refactor: restore auth page flex layout
* refactor: use toBeInTheDocument
* refactor: change recent data-test attrs to data-testid
2022-04-08 13:13:45 +02:00
Nuno Góis
1132a79f6d
fix: reject duplicate segment names ( #855 )
...
* fix: reject duplicate segment names
* fix: useSegmentValidation now takes into account initial value
* refactor: add segments e2e test
* refactor: add github action from segments e2e test
* refactor: use enterprise edition for all e2e tests
* refactor: use enterprise edition for all e2e tests
2022-04-08 11:34:59 +01:00
olav
f59ba567fb
refactor: add segment limit warnings ( #851 )
...
* refactor: fix environment name text alignment
* refactor: use rounded corners for AutocompleteBox
* refactor: add tooltips to the strategy segment icons
* refactor: add segment limit warnings
* refactor: improve segments warning text
2022-04-07 14:47:24 +02:00
olav
dbb62631a6
feat: add FeedbackCES component ( #826 )
...
* refactor: add screen-reader-only util class
* refactor: move FeedbackNPS component
* feat: add FeedbackCES component
* refactor: improve hidden checkbox styles
* refactor: fix IFeedbackEndpointRequestBody source type
* refactor: remove unnecessary event.persist() calls
* refactor: remove disableEscapeKeyDown from FeedbackCES modal
* refactor: make textarea label customizable
* refactor: store feedback state on the backend
* refactor: add FeedbackCESForm snapshot test
* refactor: use extant IAuthFeedback type
* refactor: fix showNPSFeedback logic for multiple feedback types
2022-03-31 09:23:46 +02:00
Youssef Khedher
eeda7ab5e4
feat: add segments ( #780 )
...
* feat: create segmentation structure and list
* feat: remove unused deps and change route
* feat: change header style and add renderNoSegments
* fix: style table header
* feat: create useSegments hook
* feat: add segmentApi hook
* feat: create segment
* fix: errors
* feat: add contextfields list
* fix: remove user from create segment api
* feat: add form structure
* feat: add SegmentFormStepOne
* fix: tests and routes
* feat: add constraint view
* feat: UI to match the sketch
* feat: add constraint on context select
* fix: duplication
* fix adding constraints
Co-authored-by: olav <mail@olav.io>
* fix: input date not showing up in constraint view
Co-authored-by: olav <mail@olav.io>
* fix: minor bugs
Co-authored-by: olav <mail@olav.io>
* fix: create context modal in segment page
Co-authored-by: olav <mail@olav.io>
* fix: validate constraint before create segment
Co-authored-by: olav <mail@olav.io>
* feat: create useSegment hook
Co-authored-by: olav <mail@olav.io>
* feat: create edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move constraint validation endpoint
* refactor: add missing route snapshot
* refactor: fix segment constraints unsaved/editing state
* refactor: remove create segment from mobile header menu
* refactor: update segments form description
* refactor: extract SegmentFormStepList component
* refactor: add an optional FormTemplate docs link label
* refactor: fix update segment payload
* feat: finish edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move step list above segment form
* fix: update PR based on feedback
Co-authored-by: olav <mail@olav.io>
* refactor: fix constraint validation endpoint path
* refactor: improve constraint state field name
* refactor: extract AutocompleteBox component
* feat: add strategy segment selection
* refactor: add strategy segment previews
* refactor: fix double section separator line
* feat: disable deleting a usable segment
* refactor: warn about segments without constraints
* refactor: update text in delete segment dialogue
* refactur: improve arg names
* refactor: improve index var name
* refactor: clarify steps list logic
* refactor: use a required prop for the segment name
* refactor: use ConditionallyRender for segment deletion
* refactor: fix segments refetch
* refactor: improve CreateUnleashContext component names
* refactor: adjust segment form styles
* refactor: adjust text
* refactor: fix info icon tooltip hover target
* refactor: add missing aria attrs to preview button
* refactor: add strat name to delete segment modal
* refactor: fix segment chip text alighment
* refactor: use bulk endpoint for strategy segments
* refactor: fix imports after merge
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: olav <mail@olav.io>
2022-03-29 09:30:57 +02:00
