Thomas Heartman
a0a15416c4
feat: display potential conflicts in existing change requests ( #5521 )
...
This update displays schedule conflicts in active change requests (any
CR that isn't applied, canceled, or rejected).
2023-12-04 13:33:28 +01:00
andreas-unleash
02451baaf2
feat: hide change actions when change request is scheduled ( #5514 )
...
Added 'Scheduled' state to the check for non-pending change requests
Closes #
[1-1680](https://linear.app/unleash/issue/1-1680/remove-edit-change-ui-when-cr-is-scheduled )
<img width="868" alt="Screenshot 2023-11-30 at 11 54 44"
src="https://github.com/Unleash/unleash/assets/104830839/8e6afec5-1353-4030-b49b-4a8f3eaee5f6 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-30 12:52:29 +02:00
andreas-unleash
8ffc92af5b
fix: Only show strategy variant changes if there is a diff in the variants ( #5353 )
...
What it says on the box
Closes #
[1-1652](https://linear.app/unleash/issue/1-1652/remove-the-variants-from-change-request-page-when-not-modified )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-22 09:50:03 +02:00
andreas-unleash
0dc5f306cc
Feat: change request scheduled timeline ( #5346 )
...
Adds the scheduled state to the timeline
Closes #
[1-1632](https://linear.app/unleash/issue/1-1632/update-the-progress-bar-for-scheduled-changes )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-17 11:20:14 +02:00
Jaanus Sellin
069d90d8cb
fix: date should sort asc/desc properly ( #5335 )
2023-11-14 14:47:28 +02:00
andreas-unleash
180c0dceae
Fix/scheduled request UI ( #5318 )
...
Change timezone format
Fixes a bug where the Edit button on hover being elongated
Before:
<img width="755" alt="Screenshot 2023-11-09 at 21 36 01"
src="https://github.com/Unleash/unleash/assets/104830839/189f21d5-8a68-4d6b-b094-b518749a9b2f ">
After:
<img width="812" alt="Screenshot 2023-11-09 at 22 09 26"
src="https://github.com/Unleash/unleash/assets/104830839/9056f995-bd2b-4353-8526-77160e49e990 ">
Adds the missed onClick to the edit button to show the dialog
Fixes a bug with ScheduleChangesDialog onClose
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-10 11:22:03 +02:00
andreas-unleash
100c22b42a
Feat: scheduled change request badges ( #5300 )
...
Adds a new badge to strategies that have changes in an a scheduled
change request
Closes #
[1-1620](https://linear.app/unleash/issue/1-1620/create-a-new-badge-for-flag-that-is-part-of-scheduled-change )
<img width="1671" alt="Screenshot 2023-11-09 at 11 49 53"
src="https://github.com/Unleash/unleash/assets/104830839/596abbc0-f9ab-4642-9ed2-79ef50fb6c05 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
2023-11-09 13:48:29 +02:00
andreas-unleash
3e9d88f789
Feat/scheduled cr UI tests ( #5296 )
...
Ui tests scheduled change requests
Closes # [1-1598](https://linear.app/unleash/issue/1-1598/e2e-ui-tests )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
2023-11-08 14:28:16 +02:00
Tymoteusz Czech
06d62278dc
fix: change request table sort type ( #5295 )
2023-11-07 17:13:43 +01:00
andreas-unleash
addda5b022
feat: schedule changes dialog ( #5285 )
...
Closes: #
[1-1585](https://linear.app/unleash/issue/1-1585/reschedule-changes-dialog )
[1-1582](https://linear.app/unleash/issue/1-1582/change-apply-changes-apply-or-schedule-changes )
Manually tested e2e -> Approve -> Schedule -> Reschedule ->
Apply/Reject: ui tests verifying it in next pr
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2023-11-07 10:59:49 +02:00
andreas-unleash
2262ca1be6
Feat: scheduled change request dialogs ( #5267 )
...
Creates the Apply and Reject scheduled change request dialogs
Closes #
[1-1584](https://linear.app/unleash/issue/1-1584/add-modal-for-apply-now )
Closes #
[1-1586](https://linear.app/unleash/issue/1-1586/reject-changes-dialog )
<img width="1669" alt="Screenshot 2023-11-03 at 14 43 17"
src="https://github.com/Unleash/unleash/assets/104830839/832edb8e-1da1-4d96-a5c3-4fa0cd336fea ">
<img width="1669" alt="Screenshot 2023-11-03 at 14 43 28"
src="https://github.com/Unleash/unleash/assets/104830839/f9028671-e5e1-441c-886b-1e562c83f214 ">
UI e2e tests will be in a follow up PR
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-06 11:13:50 +02:00
andreas-unleash
6b637d5fa9
feat: scheduled change request state ( #5261 )
...
Adds the scheduled state to ChangeRequestOverview.tsx
<img width="1523" alt="Screenshot 2023-11-03 at 12 52 07"
src="https://github.com/Unleash/unleash/assets/104830839/710b5f26-04a0-4ee9-b646-8ff3090ad86a ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-03 15:02:51 +02:00
Thomas Heartman
7cf998c509
fix: move useUiFlag before "return null" to avoid rendering more hooks on the first render ( #5258 )
...
Move the hook to before the first return to avoid React erroring out.
2023-11-03 10:04:03 +00:00
Thomas Heartman
9fbb61a1c4
chore: add schedule option to approved change requests ( #5252 )
...
The button doesn't do anything at the moment, but it's there visually.
Because this uses the same button as the dual-function button for
approve/reject, I extracted that component into a reusable
"multi-action" button. I could have copied the code wholesale, but it's
a complex component, so I thought this would be a better solution.
I'll add the dialog in a follow-up PR. This one already has a lot of
changes.
Visual:
2023-11-03 08:46:06 +01:00
Nuno Góis
347c1cabbc
feat: add new sticky component to handle stacked stickies ( #5088 )
...
https://linear.app/unleash/issue/2-1509/discovery-stacked-sticky-elements
Adds a new `Sticky` element that will attempt to stack sticky elements
in the DOM in a smart way.
This needs a wrapping `StickyProvider` that will keep track of sticky
elements.
This PR adapts a few components to use this new element:
- `DemoBanner`
- `FeatureOverviewSidePanel`
- `DraftBanner`
- `MaintenanceBanner`
- `MessageBanner`
Pre-existing `top` properties are taken into consideration for the top
offset, so we can have nice margins like in the feature overview side
panel.
### Before - Sticky elements overlap 😞
### After - Sticky elements stack 😄
2023-10-19 15:50:37 +01:00
Mateusz Kwasniewski
af50fc2fd3
feat: visualize dependencies managment in change requests ( #4978 )
2023-10-10 10:36:13 +02:00
Mateusz Kwasniewski
80eb6e12c6
refactor: custom render should provide container ( #4938 )
2023-10-06 09:19:49 +02:00
Gastón Fournier
bd8b54b5bd
fix: yarn lint:fix ( #4917 )
...
## About the changes
Running yarn lint:fix solves errors in frontend
2023-10-04 11:28:05 +02:00
andreas-unleash
c1f8929ddf
fix: separate project and project enterprise settings forms ( #4911 )
...
Separates ProjectForm and ProjectEnterpriseSettings forms
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2023-10-04 10:42:02 +03:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Mateusz Kwasniewski
40dfb927e9
feat: parent and child info in feature overview header ( #4901 )
2023-10-02 11:47:48 +02:00
Fredrik Strand Oseberg
d3e01d84d9
fix: account for array length ( #4849 )
...
Small fix to account for array length in conditional check
2023-09-27 15:12:01 +02:00
Fredrik Strand Oseberg
cefbf01934
feat: visualize feature variants on cr ( #4809 )
...
Adds a view over feature strategy variants on addStrategy or
editStrategy action
2023-09-22 16:17:41 +02:00
Mateusz Kwasniewski
a0fbad26bf
feat: persistent search queries ( #4624 )
2023-09-06 15:46:10 +02:00
Mateusz Kwasniewski
2b85eed5b5
feat: Search UI improvements ( #4613 )
2023-09-06 10:50:20 +02:00
Mateusz Kwasniewski
5ae86ef196
chore: Change request flags removed ( #4601 )
2023-09-04 10:57:13 +02:00
Nuno Góis
b4ef343d22
refactor: clean up some unused imports ( #4597 )
...
Should help cleaning up some of these:
2023-09-01 15:32:15 +01:00
Jaanus Sellin
b2aa3ea049
feat: change request ui updates ( #4574 )
2023-08-27 20:35:27 +03:00
Mateusz Kwasniewski
cc62db46fb
feat: archive toggles in change request UI ( #4563 )
2023-08-25 13:38:57 +02:00
Mateusz Kwasniewski
f881103701
fix: diff component for ordering ( #4552 )
2023-08-23 12:17:59 +02:00
Mateusz Kwasniewski
0e162362e6
feat: Change request advanced search and filter ( #4544 )
2023-08-23 09:38:10 +02:00
Mateusz Kwasniewski
8a7f488147
feat: reject timeline state ( #4517 )
2023-08-16 15:39:39 +02:00
Mateusz Kwasniewski
b6830b805b
feat: review buttons makeover ( #4513 )
2023-08-16 13:55:18 +02:00
Mateusz Kwasniewski
67ef0507a1
feat: link to change request configuration ( #4494 )
2023-08-15 14:18:02 +02:00
Mateusz Kwasniewski
c58d325173
feat: reject change request dialog ( #4491 )
2023-08-15 12:49:40 +02:00
Mateusz Kwasniewski
3227e30f12
feat: Change request reject UI ( #4489 )
2023-08-15 09:08:26 +02:00
Mateusz Kwasniewski
0a27b5f44a
feat: use update count in cr summary ( #4482 )
2023-08-11 14:59:59 +02:00
Jaanus Sellin
12dfb1f3eb
feat: add margin for segment constraints ( #4481 )
2023-08-11 14:07:41 +02:00
Mateusz Kwasniewski
c1fe43fe64
fix: diff no changes ( #4480 )
2023-08-11 12:31:23 +02:00
Jaanus Sellin
0e4485d0fc
feat: segment constraints in UI ( #4472 )
2023-08-10 20:12:17 +03:00
Jaanus Sellin
c1314a8ee8
feat: delete segment from CR ( #4469 )
2023-08-10 15:56:15 +03:00
Mateusz Kwasniewski
84cbd669eb
feat: count segment changes ( #4468 )
2023-08-10 14:40:44 +02:00
Mateusz Kwasniewski
0a233ba519
feat: cr sidebar segments count ( #4466 )
2023-08-10 12:01:52 +02:00
Thomas Heartman
fe0c7087de
Add name with change info to segment changes (1-1230-update-name-change) ( #4459 )
...
Extract and reuse the component that we use for strategy name changes.
## Discussion points:
This impl only shows the new name in the second field (editing segment).
Should we show it in both? Why do we have both? Do we have UI designs
for this?
2023-08-09 16:15:14 +02:00
Thomas Heartman
2531819222
fix: CR strategy name changes code ( #4449 )
...
This change addresses two things that were done in
https://github.com/Unleash/unleash/pull/4004 and that I believe to be
bugs.
1. It shows the previous strategy name also if there was no previous
title. So if there was no previous title, it'll show the strategy name
with a strikethrough and then the new title (see the discussion
section).
2. It changes a `span` component to a [`del`
component](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/del ).
I believe the
span was erroneously changed from a `s` component (strikethrough
component) in the linked PR (based on a comment on the PR). This
caused the strikethrough to not be there anymore. However, the `del`
component is semantically more correct and reintroduces the
strikethrough, so it is a better change.
3. It uses [`ins`
elements](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ins )
for names that have changed.
Finally, it removes a redundant pair of curly braces.
How it looks now:
## Discussion
Regarding point 1: It might be that we don't want to show a
strikethrough through the name of the strategy if there was no previous
title. In that case, the changes related to the first point should be
removed. If we do that, it looks like this:
It makes it harder (impossible, actually) to see when a custom title was
added, but that might be what we want.
But maybe the solution is to also use `ins` elements for new data. That
way the difference is visible (and semantically correct):
2023-08-09 12:47:02 +00:00
Mateusz Kwasniewski
c549280e31
fix: Performance improvements for demo and docs update ( #4454 )
2023-08-09 12:58:03 +02:00
Thomas Heartman
e7ae1ff714
Feat( #4209 ): add conflict marker to segment changes ( #4447 )
...
In doing so, we extract the shared conflict marker component from the
feature change and reuse it for both feature and segment changes.
Here's what it looks like:
Update: also straightened out the borders of the conflict warning:
2023-08-08 12:36:45 +00:00
Thomas Heartman
18b5161ade
chore( #4209 ): minor front-end fixes ( #4437 )
...
This PR fixes links to segments from change requests and the bottom
border radius for segment change boxes.
Old border radius:
New border radius:
2023-08-07 13:39:24 +00:00
Jaanus Sellin
7a32eacecb
feat: segments in pending CR screen ( #4420 )
2023-08-04 15:34:03 +03:00
andreas-unleash
579b08be27
fix: UI improvements on CR reorder strategy ( #4375 )
...
- make the blocks that hold the constraints full width
- remove the margin-top and margin-bottom from the parent div + increase
the gap: 20px on this parent div
- remove the margin-bottom from the constraints containers
- add the strategies in a div and add a margin-bottom: 8px
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-07-31 16:25:06 +03:00
