1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-09 11:14:29 +02:00
Commit Graph

4 Commits

Author SHA1 Message Date
Thomas Heartman
cb4beb71ac
Chore(1 3895)/small input tweaks (#10316)
Doesn't clear the value from the constraint input value popover if you
close it and then re-open. In other words, if you accidentally click
out, you don't lose your progress. Instead, the popover will open again,
with the value you had when you closed it highlighted (so that it's easy
to type over if you want to):

<img width="452" alt="image"
src="https://github.com/user-attachments/assets/d86aa00e-4956-40a8-8fea-e75be5d5425b"
/>

The reason I'm changing this now is because I noticed that the error
wasn't cleared correctly when the popover was closed. If we do it this
way instead, then that makes sense, because you can still see the value.
This is also how the single-value popover has worked forever.

From some quick testing, the single value popover still works as
expected:
<img width="562" alt="image"
src="https://github.com/user-attachments/assets/9041a922-b055-4310-ab60-93ad219981a4"
/>


As a side note: I'm adding a comment to anyone coming after as to why
focus handling on escape doesn't work correctly on the single value
button. I was about to go down a rabbit hole on that before I read my
own comment on the previous PR. So I thought I'd put that here too.
2025-07-04 14:57:52 +02:00
Nuno Góis
c5ddcdbc3c
chore: allow backdrop click through on AddValuesPopover (#10214)
Follow-up to: https://github.com/Unleash/unleash/pull/10213

This makes our `AddValuesPopover` backdrop click-through. This means you
can interact with any element in the "background" right away and it will
work, while closing the popover at the same time.

If this works well it may be worth extracting to a reusable
ClickThroughPopover or similar.
2025-06-30 08:14:23 +01:00
Nuno Góis
ce55d60804
chore: fix demo by adapting to new constraints flow (#10213)
https://linear.app/unleash/issue/2-3641/fix-demo-by-adapting-to-the-new-constraints-flow

This fixes our demo by adapting to the new constraints flow and
components.

The new `onStep` handler should allow us to hack our way around most
scenarios.
2025-06-25 17:26:03 +01:00
Thomas Heartman
a2723ec0c0
chore remove and clean some stuff (#9993)
- Deletes an unused file
- Fixes a console.error due to a prop being passed on to the HTML
component
- Puts all editable constraint files within a separate directory.
2025-05-15 07:23:33 +00:00