1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-01 00:08:27 +01:00
unleash.unleash/frontend/src/component
Thomas Heartman 344e599b09
fix: don't cut off hover-color of favorite button (#7691)
This PR fixes a minor visual issue where the "favorite project" button's
hover outline would get cut off due to its container having `overflow:
hidden`.

The overflow value was introduced in
[#7575](https://github.com/Unleash/unleash/pull/7575) as way to handle
long project names. We didn't discover the hover issue back then because
it's not apparent unless you hover the fav star.

I found the solution in the CSS-tricks post [Preventing a Grid
Blowout](https://css-tricks.com/preventing-a-grid-blowout/). To quote
the article, the reason this works is that:

> the minimum width of a grid column is auto. (The same is true for flex
items, by the way.)
>
> And since auto is entirely based on content, we can say it is
“indefinitely” sized, its dimensions flex. If we were to put an explicit
width on the column, like 50% or 400px, then we would say it is
“definitely” sized.
>
> To apply our fix, we need to make sure that there is the column has a
definite minimum width instead of auto.

Before:

![image](https://github.com/user-attachments/assets/d9296afd-326e-4712-a389-f1bc3a1f821e)


After:

![image](https://github.com/user-attachments/assets/2fd88a51-08be-4bc4-8969-cd6ebbaf255c)

Additionally, I've removed a duplicate declaration of font size,
removing the deprecated version.
2024-07-29 17:03:47 +02:00
..
accessOverview
admin fix: add workaround for tooltip (#7649) 2024-07-24 09:33:29 +00:00
application feat: redirect to new feature flag creation (#7679) 2024-07-26 14:27:02 +03:00
archive
banners
changeRequest
commandBar fix: project icon sizing and color (#7672) 2024-07-26 10:26:16 +02:00
common feat: Use a toggling button for impression data on/off (#7682) 2024-07-29 08:05:35 +00:00
context
demo
environments chore: don't prevent users from entering the env form when they're at the limit (#7549) 2024-07-05 13:11:00 +02:00
events fix: break long project/flag names in the event log to prevent overflow (#7684) 2024-07-29 08:54:43 +00:00
feature fix: use nested flexboxes instead of grid area (#7654) 2024-07-29 12:55:52 +02:00
featureTypes
feedback
feedbackNew
filter
insights feat: health stats insights explanation (#7690) 2024-07-29 15:19:20 +02:00
integrations Feat: webhook markdown (#7658) 2024-07-25 09:45:20 +00:00
layout fix: project icon sizing and color (#7672) 2024-07-26 10:26:16 +02:00
loginHistory
maintenance
menu
playground/Playground
project fix: don't cut off hover-color of favorite button (#7691) 2024-07-29 17:03:47 +02:00
providers
segments feat: limit segments component (#7553) 2024-07-08 09:03:08 +02:00
signals
splash
strategies
tags feat: separate command bar and search hotkeys (#7651) 2024-07-24 12:46:03 +03:00
user feat: Disallow repeating last 5 passwords. (#7552) 2024-07-09 16:18:35 +02:00
App.tsx fix: make loader not exlpode to 100vh in unnecessary locations (#7589) 2024-07-15 14:41:45 +02:00
InitialRedirect.tsx fix: use a fullscreen loader for the initial redirect load (#7619) 2024-07-18 14:50:59 +02:00