mirror of
https://github.com/Unleash/unleash.git
synced 2024-10-18 20:09:08 +02:00
6b4efb9a9d
https://linear.app/unleash/issue/2-943/adr-separate-request-and-response-types-in-apis During the updating of our OpenAPI documentation, we've seen several times that our schemas are either way too wide for a response or way to strict for a request. This is usually due to us reusing the same schema for both request and response. We should write an ADR where we reason about the usefulness of code duplication and keeping separate response and request schemas. Based on our needs, this PR adds my suggested ADR. --------- Co-authored-by: Simon Hornby <liquidwicked64@gmail.com>
2.0 KiB
2.0 KiB
| title |
|---|
| ADR Overview |
Introduction
Architectural decision records are a record of design decisions we have made in the past because we belived they would help our code quality over time. Any ADR can be challenged, but two conditions must be met to change an ADR:
- The proposed solution must provide a tangible benefit in terms of code quality.
- The benefits of the proposed solution must outweigh the effort of retroactively changing the entire codebase. One such example is the decision to re-write Unleash to TypeScript.
Overarching ADRs
These ADRs describe decisions that concern the entire codebase. They apply to back-end code, front-end code, and code that doesn't neatly fit into either of those categories.
Back-end ADRs
We are in the process of defining ADRs for the back end. At the time of writing we have created the following ADRS:
Front-end ADRs
We have created a set of ADRs to help guide the development of the front end:
- Component naming
- Interface naming
- Preferred component props usage
- Preferred export
- Preferred function type
- Preferred style import placement
- Preferred styling method
- Preferred data mutation method
- Preferred data fetching method
- Preferred folder structure
- Preferred form architecture
- OpenAPI SDK generator