1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
unleash.unleash/src
Gastón Fournier 9398bd969e
fix: Client metrics name validation (#4339) (#4342)
1. Add a test for the failing use case (we can see it
[here](https://github.com/Unleash/unleash/actions/runs/5656229196/job/15322845002?pr=4339#step:5:783)):
```
FAIL src/lib/services/client-metrics/metrics-service-v2.test.ts
  ● process metrics properly even when some names are not url friendly

    ValidationError: "name" must be URL friendly
```
2. Fix and handle this gracefully
3. Added a new toggle to silently ignore bad names:
filterInvalidClientMetrics

Fixes: https://github.com/Unleash/unleash/pull/4193
2023-07-25 13:33:21 +00:00
..
lib fix: Client metrics name validation (#4339) (#4342) 2023-07-25 13:33:21 +00:00
mailtemplates
migrations #4205: mark potentially stale features (#4217) 2023-07-13 12:02:33 +00:00
test fix: group cleanup (#4334) 2023-07-24 11:05:55 +02:00
migrator.ts
server-dev.ts feat: advancedPlayground flag used only for runtime control (#4262) 2023-07-18 08:49:04 +02:00
server.ts