1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-19 17:52:45 +02:00
unleash.unleash/src/lib
Gastón Fournier 9398bd969e
fix: Client metrics name validation (#4339) (#4342)
1. Add a test for the failing use case (we can see it
[here](https://github.com/Unleash/unleash/actions/runs/5656229196/job/15322845002?pr=4339#step:5:783)):
```
FAIL src/lib/services/client-metrics/metrics-service-v2.test.ts
  ● process metrics properly even when some names are not url friendly

    ValidationError: "name" must be URL friendly
```
2. Fix and handle this gracefully
3. Added a new toggle to silently ignore bad names:
filterInvalidClientMetrics

Fixes: https://github.com/Unleash/unleash/pull/4193
2023-07-25 13:33:21 +00:00
..
__snapshots__ fix: Client metrics name validation (#4339) (#4342) 2023-07-25 13:33:21 +00:00
addons feat: slack app addon default channels (#4308) 2023-07-21 14:15:43 +01:00
db fix: missing events in the event store (#4335) 2023-07-24 13:04:23 +00:00
domain/project-health
error refactor: move status codes into classes (#4200) 2023-07-11 09:20:11 +02:00
features fix: group cleanup (#4334) 2023-07-24 11:05:55 +02:00
middleware fix: reduce severity of api token middleware errors (#4216) 2023-07-11 13:33:02 +03:00
openapi fix: global role is called root role (#4336) 2023-07-24 15:27:07 +02:00
proxy
routes openapi: update ui-config endpoints (#4280) 2023-07-19 17:18:47 +02:00
schema
segments feat: client api with proper client segments and strategy variants (#4244) 2023-07-14 13:25:31 +02:00
services fix: Client metrics name validation (#4339) (#4342) 2023-07-25 13:33:21 +00:00
types fix: Client metrics name validation (#4339) (#4342) 2023-07-25 13:33:21 +00:00
util fix: correct escaping of ui flags for plausible (#3907) 2023-07-07 17:40:37 +02:00
app.test.ts
app.ts
create-config.test.ts
create-config.ts
default-custom-auth-deny-all.ts
internals.ts
logger.test.ts fix: convert more tests to typescript 2021-09-14 20:30:37 +02:00
logger.ts
metric-events.ts
metrics.test.ts
metrics.ts
server-impl.test.ts
server-impl.ts feat: improve slack app addon scalability (#4284) 2023-07-20 13:37:06 +01:00