1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-11-01 19:07:38 +01:00
unleash.unleash/frontend
David Leek 792d0e42de
feat: add projectid to the segments table (#3287)
https://linear.app/unleash/issue/2-742/add-an-extra-column-in-global-segments-configuration-to-display-the

<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->

## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

Adds projectid column to the segments table and defaults to the value
"Global" if none is set.


![image](https://user-images.githubusercontent.com/707867/224053267-e52a398a-6f89-4d27-bd52-72b73eedc99a.png)


<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->
SegmentTable.tsx

## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->

---------

Co-authored-by: Nuno Góis <github@nunogois.com>
2023-03-10 14:45:10 +01:00
..
cypress Feat/notifications cypress (#3244) 2023-03-08 12:47:42 +02:00
public refactor: adapt to Vite (#940) 2022-05-05 16:15:22 +01:00
src feat: add projectid to the segments table (#3287) 2023-03-10 14:45:10 +01:00
.editorconfig add editorconfig 2016-12-05 23:08:32 +01:00
.gitignore Feat/grouping fixes (#1146) 2022-07-25 10:14:02 +00:00
.nvmrc chore(deps): update node.js to v14.21.1 (#2385) 2022-11-10 15:58:42 +01:00
.prettierignore Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
.prettierrc refactor: format files (#719) 2022-02-18 09:51:10 +01:00
cypress.json chore: update cypress (#1170) 2022-08-01 11:50:59 +02:00
index.html ui flags replaced in index.html (#2617) 2022-12-07 14:31:27 +02:00
index.js fix: expose unleash-frontend version in index.js (#661) 2022-04-08 11:45:23 +02:00
orval.config.js Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
package.json chore(deps): update dependency swr to v2.0.4 (#3281) 2023-03-09 12:46:05 +00:00
README.md Refactor/lazy load (#2842) 2023-01-12 11:34:45 +01:00
tsconfig.json Add multiple tags (#3032) 2023-02-03 12:28:06 +02:00
tsconfig.node.json Orval generator POC (#2724) 2023-01-05 11:57:53 +01:00
vercel.json fix: update vercel proxy paths (#2623) 2022-12-07 13:00:51 +01:00
vite.config.ts fix: preload error (#2980) 2023-01-24 20:40:03 +01:00
yarn.lock chore(deps): update dependency swr to v2.0.4 (#3281) 2023-03-09 12:46:05 +00:00

frontend

This directory contains the Unleash Admin UI frontend app.

Run with a local instance of the unleash-api

First, start the unleash-api backend on port 4242. Then, start the frontend dev server:

cd ~/frontend
yarn install
yarn run start

Run with a sandbox instance of the Unleash API

Alternatively, instead of running unleash-api on localhost, you can use a remote instance:

cd ~/frontend
yarn install
yarn run start:sandbox

Running end-to-end tests

We have a set of Cypress tests that run on the build before a PR can be merged so it's important that you check these yourself before submitting a PR. On the server the tests will run against the deployed Heroku app so this is what you probably want to test against:

yarn run start:sandbox

In a different shell, you can run the tests themselves:

yarn run e2e:heroku

If you need to test against patches against a local server instance, you'll need to run that, and then run the end to end tests using:

yarn run e2e

You may also need to test that a feature works against the enterprise version of unleash. Assuming the Heroku instance is still running, this can be done by:

yarn run start:enterprise
yarn run e2e

Generating the OpenAPI client

The frontend uses an OpenAPI client generated from the backend's OpenAPI spec. Whenever there are changes to the backend API, the client should be regenerated:

./scripts/generate-openapi.sh

This script assumes that you have a running instance of the enterprise backend at http://localhost:4242. The new OpenAPI client will be generated from the runtime schema of this instance. The target URL can be changed by setting the UNLEASH_OPENAPI_URL env var.

Analyzing bundle size

npx vite-bundle-visualizer in the root of the frontend directory