mirror of
https://github.com/Unleash/unleash.git
synced 2025-10-13 11:17:26 +02:00
e4ead3bd67
This (admittedly pretty big) PR removes a component layer, moves all
logic for updating constraint values into a single module, and dumbs
down other components.
The main changes are:
- EditableConstraintWrapper is gone. All the logic in there has been
moved into the new `useEditableConstraint` hook. Previously it was split
between the wrapper, editableConstraint itself, the legalValues
component.
- the `useEditableConstraint` hook accepts a constraint and a save
function and returns an editable version of that constraint, the
validator for input values, a function that accepts update commands,
and, when relevant, existing and deleted legal values.
- All the logic for updating a constraint now exists in the
`constraint-reducer` file. As a pure function, it'll be easy to unit
test pretty thoroughly to make sure all commands work as they should
(tests will come later)
- The legal values selector has been dumbed down consiberably as it no
longer needs to create its own internal weak map. The internal
representation of selected values is now a set, so any kind of lookup is
now constant time, which should remove the need for the extra layer of
abstraction.
## Discussion points
I know the reducer pattern isn't one we use a *lot* in Unleash, but I
found a couple examples of it in the front end and it's also quite
similar to how we handle state updates to change request states. I'd be
happy to find a different way to represent it if we can keep it in a
single, testable interface.
Semi-relatedly: I've exposed the actions to submit for the updates at
the moment, but we could map these to functions instead. It'd make
invocations a little easier (you wouldn't need to specify the action
yourself; only use the payload as a function arg if there is one), but
we'd end up doing more mapping to create them. I'm not sure it's worth
it, but I also don't mind if we do 💁🏼
|
||
|---|---|---|
| .. | ||
| FeatureStrategyConstraintAccordionList | ||
| RecentlyUsedConstraints | ||
| useEditableConstraint | ||
| AddSingleValueWidget.tsx | ||
| AddValuesPopover.tsx | ||
| AddValuesWidget.tsx | ||
| ConstraintDateInput.tsx | ||
| ConstraintOperatorSelect.tsx | ||
| ConstraintValueSearch.tsx | ||
| EditableConstraint.tsx | ||
| FeatureStrategyConstraints.tsx | ||
| LegalValuesSelector.tsx | ||
| resolve-legal-values.ts | ||
| ValueList.tsx | ||