mirror of
https://github.com/Unleash/unleash.git
synced 2025-10-13 11:17:26 +02:00
d32990ec4c
This change fixes an issue with the loader where it would explode its parent component to 100vh even when that was not called for. To do so, I've added the a new `type` prop to the component, to distinguish between `fullscreen` and `inline` usage. The `fullscreen` type sets the height to 100vh, while the `inline` type sets it to 100%. Now, this doesn't directly make the loader fullscreen (it just makes sure it's at least as tall as the screen), so maybe the prop name is misleading. I'd be happy to change it (or to even extract this into two separate components) if that's preferable. Other potential prop names could be `height`, which is very direct, or `usage`, which I think better describes what we do. Like with `type`, I'd like to communicate the intended behavior more that the actual implementation, so I'm leaning towards either `type` or `usage`. ## Screenies I've gone through all the usages of the loader, and checked how each one works. Here they are: ### Loader in environment variants I wasn't able to trigger this manually, but it's apparently there Old (ignore the banner placement; that's firefox's screenshot tool acting up)  New:  ### Project setting forms Old:  New:  ### Rollout strategy Old:  New (no discernible change):  ### Advanced playground Old:  New:  ### Loading screen / initial redirect Old:  New (no new component props):  New (with new props):  |
||
|---|---|---|
| .. | ||
| accessOverview | ||
| admin | ||
| application | ||
| archive | ||
| banners | ||
| changeRequest | ||
| commandBar | ||
| common | ||
| context | ||
| demo | ||
| environments | ||
| events | ||
| feature | ||
| featureTypes | ||
| feedback | ||
| feedbackNew | ||
| filter | ||
| insights | ||
| integrations | ||
| layout | ||
| loginHistory | ||
| maintenance | ||
| menu | ||
| playground/Playground | ||
| project | ||
| providers | ||
| segments | ||
| signals | ||
| splash | ||
| strategies | ||
| tags | ||
| user | ||
| App.tsx | ||
| InitialRedirect.tsx | ||